silvas added a subscriber: silvas.
Comment at: lib/Parse/Parser.cpp:2003
@@ +2002,3 @@
+Diag(Tok, diag::err_unexpected_module_start);
+// Recover by skipping content of the included submodule.
+unsigned ModuleNesting = 1;
rsmith wrote:
> This is liable
Author: abataev
Date: Wed Aug 12 02:10:54 2015
New Revision: 244719
URL: http://llvm.org/viewvc/llvm-project?rev=244719&view=rev
Log:
[OPENMP] Fix for http://llvm.org/PR24430: clang hangs on invalid input with
openmp directive
Add parsing of openmp directives inside structs/unions in C mode.
Mo
hiraditya added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp:182
@@ +181,3 @@
+ if (rhs->isEvaluatable(Context))
+eraseAssign = true;
+ // Erase if the multiplicand was assigned a value,
zaks.anna wro
hiraditya updated this revision to Diff 31904.
hiraditya added a comment.
Added comments and changed the variable name.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow2.c
Inde
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#222452, @mclow.lists wrote:
> How does this change interact with http://reviews.llvm.org/D11963 ?
The difference between this and @jroelofs's one is that this copy the
__config_site in the source directory which makes everythin
Author: klimek
Date: Wed Aug 12 02:57:16 2015
New Revision: 244722
URL: http://llvm.org/viewvc/llvm-project?rev=244722&view=rev
Log:
Reinstantiate better diagnostic, this time with a fatal error so we don't add a
dependency onto gtest from the header.
Modified:
clang-tools-extra/trunk/unitte
Ping
--
AlexDenisov
Software Engineer, http://lowlevelbits.org
> On 06 Aug 2015, at 18:15, Hans Wennborg wrote:
>
> Hi Alex,
>
> What crash is that? I don't see any PR number in the commit.
>
> Richard, what's your owner's opinion?
>
> On Wed, Aug 5, 2015 at 9:54 PM, AlexDenisov <1101.deb...@
espositofulvio added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
mclow.lists wrote:
> I'm reluctant to do this; because every include file slows down compilation -
> for every program that we com
ismail added a comment.
Tests pass but, now when I tried to compile a file with -fopenmp I get:
LINK: fatal error LNK1104: cannot open file 'libomp.lib'
libomp.lib does exist in "C:\Program Files\LLVM\lib" but I guess we need to
pass the library path down to linker.
http://reviews.llvm.org/D1
klimek added a subscriber: klimek.
klimek added a comment.
Minor nits; I'll want Alex to also take a look, as I had reviewed the original
code before, so he probably has more insightful things to say :)
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:1
@@ +1,2 @@
+//==
angelgarcia updated this revision to Diff 31911.
angelgarcia added a comment.
Run clang-format and minor fixes.
http://reviews.llvm.org/D11946
Files:
CMakeLists.txt
Makefile
ModernizeTidyModule.cpp
PassByValueCheck.cpp
PassByValueCheck.h
clang-tidy/CMakeLists.txt
clang-tidy/Makefi
hiraditya updated this revision to Diff 31913.
hiraditya added a comment.
Added free, to avoid an unrelated warning.
http://reviews.llvm.org/D9924
Files:
lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp
test/Analysis/malloc-overflow.c
test/Analysis/malloc-overflow2.c
Index:
joerg added a subscriber: joerg.
joerg added a comment.
This feels a bit like a regression. Before, libc++ works fine by just pointing
into the include directory.
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
cfe-commits mailing list
cf
On 06/05/2015 08:30 PM, Brad Smith wrote:
On 06/05/15 01:33, James Y Knight wrote:
Thanks. Openbsd doesn't seem to have a gcc spec file with it
overridden to long upstream; is it just sharing netbsd's, or is it
non-upstreamed patches?
We've never been very good at pushing our GCC / binutils b
espositofulvio added a comment.
In http://reviews.llvm.org/D11781#222572, @joerg wrote:
> This feels a bit like a regression. Before, libc++ works fine by just
> pointing into the include directory.
With my change it still is fine pointing at the include directory. But as I
said, Jonathan fee
skalinichev created this revision.
skalinichev added a reviewer: akyrtzi.
skalinichev added a subscriber: cfe-commits.
It used to work, but was accidentally broken by:
r179769 | akirtzidis | 2013-04-18 20:41:15 +0400 (Thu, 1
Hello This is Nikhil Reddy Kothapally Master Student From Technical
University of Chemnitz (Germany) in the Filed of Automotive Software
Engineering currently am writing my Master Thesis on "Memory Safety Compiler"
which is Based on all these tools of the LLVM mainline.
The main Goal is to use
klimek added a comment.
Ok, we're very close now :) Thanks for taking the time to work through this!
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299
@@ +298,3 @@
+if (CommandFound) {
+ ErrorMessage = "Multiple command and arguments fo
[ + cfe-commits@lists.llvm.org ]
Hi,
The functionality is now available under a flag, see attached patch. Note that
the flag is ignored in C++ mode, so it will help the use case of compiling
(legacy) C code with a C++ compiler.
Cheers,
Sjoerd.
From: Sjoerd Meijer [mailto:sjoerd.mei...@
davide updated this revision to Diff 31932.
davide added a comment.
- Refactored check
- Added test for -ffreestanding in C
- Changed the diagnostic emitted
Also, thanks for your time and guidance.
http://reviews.llvm.org/D11658
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/Se
alexfh added a comment.
Something weird happened with the file names in this CL after the latest
update, e.g. there are both `clang-tidy/CMakeLists.txt` and `CMakeLists.txt`.
How exactly did you create the Differential revision and update it?
Comment at: ModernizeTidyModule.cp
Author: djasper
Date: Wed Aug 12 08:16:41 2015
New Revision: 244745
URL: http://llvm.org/viewvc/llvm-project?rev=244745&view=rev
Log:
Lazily initialize HeaderFilter in ClangTidyDiagnosticConsumer. This
removes a corner case in tests that don't set the diagnostic consumer.
In tests, it is good, not
tejohnson updated the summary for this revision.
tejohnson updated this revision to Diff 31937.
tejohnson added a comment.
Removed gold plugin option.
http://reviews.llvm.org/D11908
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cp
Author: aaronballman
Date: Wed Aug 12 08:38:59 2015
New Revision: 244749
URL: http://llvm.org/viewvc/llvm-project?rev=244749&view=rev
Log:
Rangify some for loops; NFC.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/llvm-projec
jroelofs added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
espositofulvio wrote:
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation
> > - for eve
john.brawn created this revision.
john.brawn added reviewers: rafael, ab.
john.brawn added a subscriber: cfe-commits.
john.brawn set the repository for this revision to rL LLVM.
The fix for this is in LLVM but it depends on how clang handles the alias
attribute, so add a test to the clang tests t
mclow.lists added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
espositofulvio wrote:
> mclow.lists wrote:
> > I'm reluctant to do this; because every include file slows down compilation
> > - for
rcraik added a comment.
ping 2!
http://reviews.llvm.org/D11582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson abandoned this revision.
tejohnson added a comment.
Obsolete, didn't need to do this.
http://reviews.llvm.org/D9717
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tejohnson closed this revision.
tejohnson added a comment.
Committed awhile back as r236289, closing manually.
http://reviews.llvm.org/D9407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D11980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: aaronballman
Date: Wed Aug 12 10:01:15 2015
New Revision: 244751
URL: http://llvm.org/viewvc/llvm-project?rev=244751&view=rev
Log:
The version of libxml2 required by c-index-test must be at least 2.5.3.
Considering that this version was released in 2003, you might think the check a
bit r
pgousseau updated this revision to Diff 31940.
pgousseau added a comment.
Removed 'return' statements and added tests for empty arrays following Anna
review.
Refactored parameter passing of 'TK_DoNotInvalidateSuperRegion' following Anton
review, by adding a new member function 'hasTrait' to 'Clu
jroelofs added inline comments.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
jroelofs wrote:
> mclow.lists wrote:
> > espositofulvio wrote:
> > > mclow.lists wrote:
> > > > I'm reluctant to do this; because every i
Author: john.brawn
Date: Wed Aug 12 10:15:27 2015
New Revision: 244756
URL: http://llvm.org/viewvc/llvm-project?rev=244756&view=rev
Log:
Add test for PR24379
The fix for this is in LLVM but it depends on how clang handles the alias
attribute, so add a test to the clang tests to make sure everythi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244756: Add test for PR24379 (authored by john.brawn).
Changed prior to commit:
http://reviews.llvm.org/D11980?vs=31939&id=31942#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11980
Files:
cfe/t
Sorry for the miscommunication, I thought you were going to commit it
already. LGTM.
On Wed, Aug 12, 2015 at 6:37 AM, Brad Smith wrote:
> On 06/05/2015 08:30 PM, Brad Smith wrote:
>
>> On 06/05/15 01:33, James Y Knight wrote:
>>
>>> Thanks. Openbsd doesn't seem to have a gcc spec file with it ov
Author: john.brawn
Date: Wed Aug 12 10:55:55 2015
New Revision: 244760
URL: http://llvm.org/viewvc/llvm-project?rev=244760&view=rev
Log:
The alias.c test now requires arm-registered-target
This should fix a buildbot failure
Modified:
cfe/trunk/test/CodeGen/alias.c
Modified: cfe/trunk/test/C
benlangmuir updated this revision to Diff 31947.
benlangmuir added a comment.
Changes per review. I still need to check performance of code-completing
import statements to make sure the extra directory iteration isn't a big
regression.
Repository:
rL LLVM
http://reviews.llvm.org/D11403
Fi
EricWF added a reviewer: EricWF.
EricWF added a comment.
@jroelofs Thanks for this patch. I've needed this for a while.
Comment at: include/__config:19
@@ -18,1 +18,3 @@
+#include <__config_site>
+
#ifdef __GNUC__
jroelofs wrote:
> jroelofs wrote:
> > mclow.lis
angelgarcia updated this revision to Diff 31948.
angelgarcia marked 20 inline comments as done.
angelgarcia added a comment.
Fix tests and minor issues (auto, punctuation, etc).
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/modernize/CMakeL
jroelofs updated this revision to Diff 31949.
jroelofs added a comment.
Add license text to the new file, and move the two has-no-threads tests to
test/libcxx.
http://reviews.llvm.org/D11963
Files:
CMakeLists.txt
include/CMakeLists.txt
include/__config
include/__config_site.in
test/l
Author: hans
Date: Wed Aug 12 11:40:42 2015
New Revision: 244761
URL: http://llvm.org/viewvc/llvm-project?rev=244761&view=rev
Log:
ReleaseNotes: Small version nbr fix
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewvc/llvm-project
diltsman added inline comments.
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:299
@@ +298,3 @@
+if (CommandFound) {
+ ErrorMessage = "Multiple command and arguments found";
+ return false;
klimek wrote:
> Any rea
diltsman updated this revision to Diff 31952.
diltsman marked an inline comment as done.
http://reviews.llvm.org/D10365
Files:
../llvm/tools/clang/include/clang/Tooling/JSONCompilationDatabase.h
../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp
../llvm/tools/clang/unittests/Toolin
On Wed, Aug 12, 2015 at 12:10 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Wed Aug 12 02:10:54 2015
> New Revision: 244719
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244719&view=rev
> Log:
> [OPENMP] Fix for http://llvm.org/PR24430: clang hangs on invalid input with
>
On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki <
daniel.marjam...@evidente.se> wrote:
>
> ideally there should be no -Wunused-parameter compiler warning when the
> parameter is used.
>
> would it feel better to move the "FP" warnings about virtual functions,
> for instance to clang-tidy?
>
> >
Author: hans
Date: Wed Aug 12 12:15:27 2015
New Revision: 244772
URL: http://llvm.org/viewvc/llvm-project?rev=244772&view=rev
Log:
Merging r244003:
r244003 | tbrethou | 2015-08-04 20:59:14 -0700 (Tue, 04 Aug 2015) | 2 lines
Author: hans
Date: Wed Aug 12 12:16:15 2015
New Revision: 244773
URL: http://llvm.org/viewvc/llvm-project?rev=244773&view=rev
Log:
Merging r244004:
r244004 | tbrethou | 2015-08-04 21:01:26 -0700 (Tue, 04 Aug 2015) | 2 lines
Author: hans
Date: Wed Aug 12 12:16:39 2015
New Revision: 244774
URL: http://llvm.org/viewvc/llvm-project?rev=244774&view=rev
Log:
Merging r244005:
r244005 | tbrethou | 2015-08-04 21:01:47 -0700 (Tue, 04 Aug 2015) | 2 lines
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson updated this revision to Diff 31957.
nwilson added a comment.
Addressing comments which were discussed on the mailing list - Apply the same
text when diagnosing a free standing declaration as suggested by Aaron. Replace
diagnostic identifier err_concept_decl_non_template with
err_concep
dougk created this revision.
dougk added a reviewer: chandlerc.
dougk added a subscriber: cfe-commits.
http://reviews.llvm.org/D11983
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
+++ lib/
On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote:
> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki <
> daniel.marjam...@evidente.se> wrote:
>
>>
>> ideally there should be no -Wunused-parameter compiler warning when the
>> parameter is used.
>>
>> would it feel better to move the "FP" warni
On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie wrote:
>
>
> On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote:
>
>> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki <
>> daniel.marjam...@evidente.se> wrote:
>>
>>>
>>> ideally there should be no -Wunused-parameter compiler warning when the
>>
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
This is a first step towards making macro diagnostics better.
http://reviews.llvm.org/D11778
___
cfe-commits mailing list
cfe-commits@lists.llvm.
On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber wrote:
> On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie
> wrote:
>
>>
>>
>> On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber wrote:
>>
>>> On Tue, Aug 11, 2015 at 10:15 PM, Daniel Marjamäki <
>>> daniel.marjam...@evidente.se> wrote:
>>>
ideall
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244788: Stop printing macro backtraces that don't help
diagnostics. (authored by rtrieu).
Changed prior to commit:
http://reviews.llvm.org/D11778?vs=31425&id=31965#toc
Repository:
rL LLVM
http://rev
Author: rtrieu
Date: Wed Aug 12 13:24:59 2015
New Revision: 244788
URL: http://llvm.org/viewvc/llvm-project?rev=244788&view=rev
Log:
Stop printing macro backtraces that don't help diagnostics.
When displaying the macro backtrace, ignore some of the backtraces that do not
provide extra information
LGTM!
~Aaron
On Wed, Aug 12, 2015 at 1:40 PM, Nathan Wilson wrote:
> nwilson updated this revision to Diff 31957.
> nwilson added a comment.
>
> Addressing comments which were discussed on the mailing list - Apply the same
> text when diagnosing a free standing declaration as suggested by Aaron
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks fine, go ahead once you're satisfied that the performance is OK for the
`requires excluded` / umbrella dir hack.
Comment at: include/clang/Basic/Module.h:363
@@ +362,3
Author: dougk
Date: Wed Aug 12 13:36:12 2015
New Revision: 244791
URL: http://llvm.org/viewvc/llvm-project?rev=244791&view=rev
Log:
Don't compare getArchName() to "tce" as a string. NFC.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/lib/Driver/Driver.cpp
URL:
http://llvm.org
chandlerc added a comment.
This isn't necessary. The TC that we assign to is a reference to the pointer in
the map. It should already be caching.
http://reviews.llvm.org/D11983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
rsmith added a comment.
In principle, normalizing slashes on Windows makes sense here. But we shouldn't
use `llvm::sys::path::native`, because it's just too broken.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString<1024> NativeFilename;
+ llvm:
alexfh added inline comments.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:158
@@ +157,3 @@
+ Compiler.getLangOpts(),
+ IncludeSorter::IS_LLVM));
+ Compiler.getPreprocessor().addPPCallbacks(Inserter-
Author: aaronballman
Date: Wed Aug 12 14:00:39 2015
New Revision: 244792
URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev
Log:
RangRangify some more for loops; NFC.
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
U
Author: alexfh
Date: Wed Aug 12 14:29:57 2015
New Revision: 244793
URL: http://llvm.org/viewvc/llvm-project?rev=244793&view=rev
Log:
[clang-tidy] Make FileOptionsProvider fields protected to make extending it
easier
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.h
Modified: c
On 08/12/15 11:24, James Y Knight wrote:
Sorry for the miscommunication, I thought you were going to commit it
already. LGTM.
Oh, I was waiting for someone to say something. Thanks.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Author: hans
Date: Wed Aug 12 14:35:01 2015
New Revision: 244794
URL: http://llvm.org/viewvc/llvm-project?rev=244794&view=rev
Log:
Docs: update clang-cl command-line documentation
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/l
Author: hans
Date: Wed Aug 12 14:35:05 2015
New Revision: 244795
URL: http://llvm.org/viewvc/llvm-project?rev=244795&view=rev
Log:
Options.td: Drop trailing space in -fsanitize= help text
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Wed Aug 12 14:00:39 2015
> New Revision: 244792
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev
> Log:
> RangRangify some more for loops; NFC.
>
> Mo
Author: hans
Date: Wed Aug 12 14:45:01 2015
New Revision: 244797
URL: http://llvm.org/viewvc/llvm-project?rev=244797&view=rev
Log:
Docs: keep copyright years up-to-date
Modified:
cfe/trunk/docs/conf.py
Modified: cfe/trunk/docs/conf.py
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/
On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie wrote:
>
>
> On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Wed Aug 12 14:00:39 2015
>> New Revision: 244792
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244792&view=rev
>> Log:
>> R
On Wed, Aug 12, 2015 at 1:03 PM, Aaron Ballman
wrote:
> On Wed, Aug 12, 2015 at 3:37 PM, David Blaikie wrote:
> >
> >
> > On Wed, Aug 12, 2015 at 12:00 PM, Aaron Ballman via cfe-commits
> > wrote:
> >>
> >> Author: aaronballman
> >> Date: Wed Aug 12 14:00:39 2015
> >> New Revision: 244792
> >>
Author: aaronballman
Date: Wed Aug 12 15:05:18 2015
New Revision: 244802
URL: http://llvm.org/viewvc/llvm-project?rev=244802&view=rev
Log:
Switching from an explicit loop to DeleteContainerSeconds; NFC.
Modified:
cfe/trunk/lib/ASTMatchers/Dynamic/Registry.cpp
Modified: cfe/trunk/lib/ASTMatch
On Wed, Aug 12, 2015 at 11:16 AM, David Blaikie wrote:
>
>
> On Wed, Aug 12, 2015 at 11:12 AM, Nico Weber wrote:
>
>> On Wed, Aug 12, 2015 at 11:06 AM, David Blaikie
>> wrote:
>>
>>>
>>>
>>> On Wed, Aug 12, 2015 at 10:11 AM, Nico Weber
>>> wrote:
>>>
On Tue, Aug 11, 2015 at 10:15 PM, Dani
dougk created this revision.
dougk added a reviewer: chandlerc.
dougk added a subscriber: cfe-commits.
I think this conveys the intent better. Alternatively, since it's effectively
trying to take llvm::sys::path::parent_path() for a number of times determined
by the occurrences of '/' in one str
krasin updated this revision to Diff 31979.
krasin added a comment.
Windows compat
http://reviews.llvm.org/D11968
Files:
include/clang/Frontend/DependencyOutputOptions.h
include/clang/Frontend/Utils.h
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
lib/Frontend/D
krasin marked an inline comment as done.
krasin added a comment.
Please, take another look. The test for --show-includes is on the way.
http://reviews.llvm.org/D11968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
krasin updated this revision to Diff 31983.
krasin added a comment.
More tests / fix tests.
http://reviews.llvm.org/D11968
Files:
include/clang/Frontend/DependencyOutputOptions.h
include/clang/Frontend/Utils.h
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
lib/F
rsmith added a subscriber: rsmith.
rsmith added a comment.
LGTM
http://reviews.llvm.org/D11968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra created this revision.
tra added reviewers: echristo, rsmith, eliben.
tra added a subscriber: cfe-commits.
This is a somewhat different way to do it than D11666 which got rolled back.
Codegen postpones emitting instantiated kernel function template until it's
used.
If kernel is used only fro
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for working on this.
-eric
http://reviews.llvm.org/D11993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: nmusgrave
Date: Wed Aug 12 16:37:40 2015
New Revision: 244819
URL: http://llvm.org/viewvc/llvm-project?rev=244819&view=rev
Log:
Implement poisoning of only class members in dtor, as opposed to also poisoning
fields inherited from base classes.
Verify emitted code for derived class with vi
On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva wrote:
> silvas added a subscriber: silvas.
>
>
> Comment at: lib/Parse/Parser.cpp:2003
> @@ +2002,3 @@
> +Diag(Tok, diag::err_unexpected_module_start);
> +// Recover by skipping content of the included submodule.
> +unsign
eliben accepted this revision.
eliben added a comment.
lgtm
Comment at: test/CodeGenCUDA/ptx-kernels.cu:26
@@ -16,1 +25,2 @@
// CHECK: !{{[0-9]+}} = !{void ()* @global_function, !"kernel", i32 1}
+// CHECK: !{{[0-9]+}} = !{void (i32)* @_Z16templated_kernelIiEvT_, !"kernel",
i3
This patch seems a bit confused. You warn that the flag is ignored in C++,
but it only has an effect in C++. You have a testcase with a .c extension
that is built with -x c++.
On Wed, Aug 12, 2015 at 5:23 AM, Sjoerd Meijer
wrote:
> [ + cfe-commits@lists.llvm.org ]
>
>
>
> Hi,
>
> The functionali
Author: nmusgrave
Date: Wed Aug 12 17:07:24 2015
New Revision: 244820
URL: http://llvm.org/viewvc/llvm-project?rev=244820&view=rev
Log:
Revert "Implement poisoning of only class members in dtor, as opposed to also
poisoning fields inherited from base classes."
This reverts commit 8dbbf3578a9a5d0
(switching over to the new mailing list)
On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote:
>
>
> On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner
> wrote:
>
>> Author: bogner
>> Date: Tue Oct 21 12:24:44 2014
>> New Revision: 220305
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=220305&v
On Wed, Aug 12, 2015 at 6:07 PM, Naomi Musgrave via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: nmusgrave
> Date: Wed Aug 12 17:07:24 2015
> New Revision: 244820
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244820&view=rev
> Log:
> Revert "Implement poisoning of only class membe
On Wed, Aug 12, 2015 at 3:17 PM, David Majnemer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Wed, Aug 12, 2015 at 6:07 PM, Naomi Musgrave via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: nmusgrave
>> Date: Wed Aug 12 17:07:24 2015
>> New Revision: 244820
>>
>> U
Author: rsmith
Date: Wed Aug 12 17:25:24 2015
New Revision: 244822
URL: http://llvm.org/viewvc/llvm-project?rev=244822&view=rev
Log:
[modules] If loading a .pcm file would cause us to run out of source locations,
attempt to fail more gracefully. (No test; this requires >= 4GB of preprocessed
inp
On Tue, Aug 11, 2015 at 2:28 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Aug 11, 2015 at 02:06:58PM -0700, Marshall Clow via cfe-commits
> wrote:
> > On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert
> wrote:
> >
> > > Yeah, those sound like exactly what we wan
rsmith added a comment.
Looks good other than the diagnostic wording.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:513
@@ -512,1 +512,3 @@
"platform-specific data}0) must be of type %1">;
+def err_main_global_variable : Error<"main can't be declared as global
var
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11968
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: dblaikie
Date: Wed Aug 12 17:58:10 2015
New Revision: 244826
URL: http://llvm.org/viewvc/llvm-project?rev=244826&view=rev
Log:
-Wdeprecated: SavedInstanceContext is returned by value but isn't really
copyable, but it can be made movable
Modified:
cfe/trunk/lib/Sema/SemaAccess.cpp
Mo
My testing was varied. I could not get GCC or clang to optimize it away for
Linux, but both did for ARM Android.
Regardless, the fact that GCC is already doing this doesn't mean it's
desirable. We end up hunting and fixing bugs from this optimization this
every release, and our time could be bette
Author: dblaikie
Date: Wed Aug 12 18:09:24 2015
New Revision: 244829
URL: http://llvm.org/viewvc/llvm-project?rev=244829&view=rev
Log:
-Wdeprecated: Job objects are stored in a vector yet are not really copyable,
make them movable instead
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modifie
Author: dblaikie
Date: Wed Aug 12 18:16:55 2015
New Revision: 244831
URL: http://llvm.org/viewvc/llvm-project?rev=244831&view=rev
Log:
Wdeprecated: CGBuilderInserter is copy constructed in some contexts - remove
the unnecessarily disabling copy assignment to enable this
The object has very simpl
Author: dblaikie
Date: Wed Aug 12 18:49:57 2015
New Revision: 244838
URL: http://llvm.org/viewvc/llvm-project?rev=244838&view=rev
Log:
Wdeprecated: ApplyDebugLocation is returned by value yet if it is ever copied
(rather than RVO'd) that would be broken, make it movable instead
Modified:
cfe
1 - 100 of 123 matches
Mail list logo
