theraven added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
espositofulvio wrote:
> jroelofs wrote:
> > espositofulvio wrote:
> > > jroelofs wrote:
> >
espositofulvio added inline comments.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
theraven wrote:
> espositofulvio wrote:
> > jroelofs wrote:
> > > espositofulvio wrote
ABataev created this revision.
ABataev added reviewers: chandlerc, rsmith.
ABataev added a subscriber: cfe-commits.
Adds libomp.lib for -fopenmp=libomp and libiomp5md.lib for -fopenmp=libiomp5 on
Windows
http://reviews.llvm.org/D11932
Files:
lib/Driver/Tools.cpp
test/OpenMP/linking.c
Index
Author: djasper
Date: Tue Aug 11 06:02:09 2015
New Revision: 244583
URL: http://llvm.org/viewvc/llvm-project?rev=244583&view=rev
Log:
Revert "[CUDA] Add implicit __attribute__((used)) to all __global__ functions."
This is breaking internal test. I'll provide a reproduction.
Modified:
cfe/tru
ismail added a comment.
OpenMP/linking.c fails here with VS2015 (building with
-DCLANG_DEFAULT_OPENMP_RUNTIME=libomp)
Command 21 Stderr:
C:\cygwin64\home\ismail\src\llvm\tools\clang\test\OpenMP\linking.c:75:24:
error: expected string not found in input
// CHECK-MSVC-LINK-64: "link.exe"
^
:1
ABataev updated this revision to Diff 31792.
ABataev added a comment.
Test fix
http://reviews.llvm.org/D11932
Files:
lib/Driver/Tools.cpp
test/OpenMP/linking.c
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib/D
Author: klimek
Date: Tue Aug 11 06:37:48 2015
New Revision: 244586
URL: http://llvm.org/viewvc/llvm-project?rev=244586&view=rev
Log:
Add an IncludeInserter to clang-tidy.
Will be used to allow checks to insert includes at the right position.
Added:
clang-tools-extra/trunk/clang-tidy/IncludeI
I believe this breaks -fno-module-file-deps.
On Sun, Aug 9, 2015 at 6:47 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Sat Aug 8 23:46:57 2015
> New Revision: 244413
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244413&view=rev
> Log:
> [module
Author: klimek
Date: Tue Aug 11 07:02:28 2015
New Revision: 244587
URL: http://llvm.org/viewvc/llvm-project?rev=244587&view=rev
Log:
Fix shadowing of type with variable.
Modified:
clang-tools-extra/trunk/clang-tidy/IncludeInserter.cpp
Modified: clang-tools-extra/trunk/clang-tidy/IncludeInser
Author: klimek
Date: Tue Aug 11 07:13:15 2015
New Revision: 244596
URL: http://llvm.org/viewvc/llvm-project?rev=244596&view=rev
Log:
Default initialize from explicitly constructed object.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
Modified: clang-tools-extra/trunk
andreybokhanko added a comment.
John,
(Others are welcome to chime in as well)
I started to implement your suggestion, but faced with problems.
Consider the following test case:
1: struct T {
2: ~T() {}
3: };
4:
5: extern "C" void _ZN1TD1Ev();
6:
7: int main() {
8: _ZN1TD1
Author: klimek
Date: Tue Aug 11 07:59:22 2015
New Revision: 244597
URL: http://llvm.org/viewvc/llvm-project?rev=244597&view=rev
Log:
Do not use inheriting constructors.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/IncludeInserterTest.cpp
Modified: clang-tools-extra/trunk/unittests/
ayartsev added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:2359
@@ -2314,1 +2358,3 @@
+RegionAndSymbolInvalidationTraits ITraits;
+W.AddToWorkList(*I, ITraits);
}
Too much unnecessary passing around of RegionAndSymbolInvalidatio
Author: klimek
Date: Tue Aug 11 08:11:29 2015
New Revision: 244598
URL: http://llvm.org/viewvc/llvm-project?rev=244598&view=rev
Log:
Fix strict dependency uncovered by windows bot.
Modified:
clang-tools-extra/trunk/clang-tidy/CMakeLists.txt
Modified: clang-tools-extra/trunk/clang-tidy/CMakeL
Author: chapuni
Date: Tue Aug 11 08:16:51 2015
New Revision: 244599
URL: http://llvm.org/viewvc/llvm-project?rev=244599&view=rev
Log:
Also ClangTidyTests requires clangLex.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/CMakeLists.txt
Modified: clang-tools-extra/trunk/unittests/clang
danielmarjamaki added a comment.
ping. can somebody review?
http://reviews.llvm.org/D11035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: krememek.
danielmarjamaki added a subscriber: cfe-commits.
Don't diagnose -Wunused-parameter in methods that override other methods
because the overridden methods might use the parameter
Don't diagnose -Wunused-parameter in
On Mon, Aug 10, 2015 at 3:00 PM, Nathan Wilson wrote:
> nwilson created this revision.
> nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin,
> faisalv, aaron.ballman.
> nwilson added a subscriber: cfe-commits.
>
> Adding check to emit diagnostic for invalid tag when concept is
Radovan.Obradovic updated this revision to Diff 31807.
Radovan.Obradovic added a comment.
The patch is updated to be consistent with the patch for IC for LLVM.
http://reviews.llvm.org/D4724
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Option
jwillemsen added a comment.
This isn't fixed in 3.6.2, any idea when this gets into a release?
Repository:
rL LLVM
http://reviews.llvm.org/D3583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: klimek
Date: Tue Aug 11 09:21:26 2015
New Revision: 244602
URL: http://llvm.org/viewvc/llvm-project?rev=244602&view=rev
Log:
1. Disable tests that currently cannot work on windows due to missing path
canonicalization in the file manager.
2. Add better output when a clang-tidy unit test fa
klimek created this revision.
klimek added reviewers: rsmith, chapuni.
klimek added a subscriber: cfe-commits.
For virtual files to work correctly on Windows, we need to canonicalize
the paths before looking into the caches.
This is basically a request for comments - if we want to go this route,
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
There is also the case insensitivity issue, see
https://llvm.org/bugs/show_bug.cgi?id=17993
http://reviews.llvm.org/D11944
___
cfe-commits mailing list
cfe-commits@lists.llvm
Which compiler do we support that didn't accept this? I thought we'd
already grown a few uses of initializer lists like this...
On Aug 11, 2015 5:13 AM, "Manuel Klimek via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: klimek
> Date: Tue Aug 11 07:13:15 2015
> New Revision: 244596
>
>
Unsupported (which compiler(s)?) or just not preferred?
On Aug 11, 2015 6:00 AM, "Manuel Klimek via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Author: klimek
> Date: Tue Aug 11 07:59:22 2015
> New Revision: 244597
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244597&view=rev
> Log:
> D
Don't remember which bot it was; the message said something about an
explicit constructor being called for std::map
On Tue, Aug 11, 2015 at 5:00 PM David Blaikie wrote:
> Which compiler do we support that didn't accept this? I thought we'd
> already grown a few uses of initializer lists like thi
klimek added a comment.
The case sensitivity stuff is related, but a much larger problem - while the
native paths are system dependent, the case sensitivity is file system
dependent - I can have case insensitive file systems on any OS.
http://reviews.llvm.org/D11944
MSVC 2013
On Tue, Aug 11, 2015 at 5:02 PM David Blaikie wrote:
> Unsupported (which compiler(s)?) or just not preferred?
> On Aug 11, 2015 6:00 AM, "Manuel Klimek via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: klimek
>> Date: Tue Aug 11 07:59:22 2015
>> New Revision: 244597
Can't you just change your signature to
virtual void a(int /* x */) {}
in these cases?
On Tue, Aug 11, 2015 at 6:43 AM, Daniel Marjamäki <
cfe-commits@lists.llvm.org> wrote:
> danielmarjamaki created this revision.
> danielmarjamaki added a reviewer: krememek.
> danielmarjamaki added a subscr
thakis added a subscriber: thakis.
thakis added a comment.
Can't you just change your signature to
virtual void a(int /* x */) {}
in these cases?
http://reviews.llvm.org/D11940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
jroelofs added a subscriber: EricWF.
Comment at: include/__config:742
@@ +741,3 @@
+#ifndef _LIBCPP_HAS_NO_THREADS
+# if defined(__FreeBSD__) || \
+defined(__NetBSD__) || \
espositofulvio wrote:
> theraven wrote:
> > espositofulvio wrote:
> > > jroelofs wrote:
This makes it easier for tools using the Python libclang bindings to
display diagnostics in a manner consistent with clang.
---
bindings/python/clang/cindex.py | 33 +
1 file changed, 33 insertions(+)
diff --git a/bindings/python/clang/cindex.py b/bindings/python/c
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added a subscriber: cfe-commits.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
This is the first step for migrating cppmodernize to clang-tidy.
Hi,
I believe this is being sent to the correct list. Please let me know if
there is a better choice.
The clang-format option SpaceBeforeParens "Always" does not insert a space
before the opening parenthesis of an overloaded operator function. The
attached patch against trunk resolves this.
Kind
Hello,
I’m new to Clang, and I’d like to start off by saying that it's been a real
treat to work with so far.
I’ve been putting the Rewriter through its paces and found a bug: RemoveText
does not use the correct starting offset when IncludeInsertsAtBeginOfRange=true
in the RewriteOptions and s
cbeck88 created this revision.
cbeck88 added a reviewer: djasper.
cbeck88 added a subscriber: cfe-commits.
cbeck88 set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
Rationale:
I sometimes use a different clang tool, iwyu ("include what you use"), to clean
up hea
If possible, could you send to patch through reviews.llvm.org?
On Tue, Aug 11, 2015 at 1:37 PM, Jon Chesterfield via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> I believe this is being sent to the correct list. Please let me know if
> there is a better choice.
>
> The clang-format
On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
wrote:
> Author: rnk
> Date: Mon Aug 10 14:39:01 2015
> New Revision: 244488
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev
> Log:
> [dllimport] A non-imported class with an imported key can't have a key
>
> Summary:
On Mon, Aug 10, 2015 at 6:40 PM, Richard Smith
wrote:
> On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote:
>
>> On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith
>> wrote:
>>
>>> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
+
Yeah, let's do that.
On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote:
> On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits
> wrote:
> > Author: rnk
> > Date: Mon Aug 10 14:39:01 2015
> > New Revision: 244488
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev
diltsman updated this revision to Diff 31824.
http://reviews.llvm.org/D10365
Files:
../llvm/tools/clang/include/clang/Tooling/JSONCompilationDatabase.h
../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp
../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp
Index: ../ll
arsenm updated this revision to Diff 31825.
arsenm added a comment.
Update for trunk
http://reviews.llvm.org/D10586
Files:
include/clang/Basic/BuiltinsHSAIL.def
include/clang/Basic/TargetBuiltins.h
include/clang/module.modulemap
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
lib/Co
pgousseau added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1098
@@ +1097,3 @@
+ if (!NumElements)
+return;
+ QualType ElementTy = AT->getElementType();
zaks.anna wrote:
> What happens on early returns? Here and the one b
Alex Corrado writes:
> Hello,
>
> I’m new to Clang, and I’d like to start off by saying that it's been a
> real treat to work with so far.
>
> I’ve been putting the Rewriter through its paces and found a bug:
> RemoveText does not use the correct starting offset when
> IncludeInsertsAtBeginOfRange
On Aug 11, 2015 9:45 AM, "Reid Kleckner" wrote:
>
> On Mon, Aug 10, 2015 at 6:40 PM, Richard Smith
wrote:
>>
>> On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner wrote:
>>>
>>> On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith
wrote:
On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-c
Rightio - good to know. Thanks!
On Tue, Aug 11, 2015 at 8:08 AM, Manuel Klimek wrote:
> Don't remember which bot it was; the message said something about an
> explicit constructor being called for std::map
>
> On Tue, Aug 11, 2015 at 5:00 PM David Blaikie wrote:
>
>> Which compiler do we suppor
mclow.lists created this revision.
mclow.lists added reviewers: chandlerc, rsmith, EricWF.
mclow.lists added a subscriber: cfe-commits.
Herald added subscribers: danalbert, tberghammer.
The C standard says that calling `memcpy`, etc with null parameters is
undefined behavior.
GCC (and clang) have
sepavloff updated this revision to Diff 31831.
sepavloff added a comment.
Fixed module boundary treatment.
This version must fix problems in the treatment of annot_modulbegin and
annot_module_end. Error recover for the token annot_module_include found
in wrong context can be made as previously,
petarj created this revision.
petarj added a reviewer: dschuff.
petarj added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb.
Let NaClMips32ELTargetInfo inherit arch values for maximum width lock-free
atomic operations.
http://reviews.llvm.org/D11949
Files:
lib/Basic/Targets
mclow.lists added a subscriber: mclow.lists.
mclow.lists added a reviewer: mclow.lists.
mclow.lists added a comment.
I agree with @jroelofs that we don't want to `#include ` in
`<__config>`
Repository:
rL LLVM
http://reviews.llvm.org/D11781
___
tra created this revision.
tra added reviewers: eliben, echristo.
tra added a subscriber: cfe-commits.
The patch makes sure that register names in named register variables and inline
assembly are checked only on appropriate side of CUDA compilation.
http://reviews.llvm.org/D11950
Files:
lib/S
On Tue, Aug 11, 2015 at 4:57 AM, Manuel Klimek wrote:
> I believe this breaks -fno-module-file-deps.
>
I don't think so; this affects which module map files end up in the .d
file, not which .pcm files do.
> On Sun, Aug 9, 2015 at 6:47 AM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm
danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.
In http://reviews.llvm.org/D11940#221718, @thakis wrote:
> Can't you just change your signature to
>
> virtual void a(int /* x */) {}
>
>
> in these cases?
hmm.. yes I agree.
You are right, so I change my mind about
nlopes added a subscriber: nlopes.
Comment at: include/cstring:96
@@ +95,3 @@
+int strncmp(const char* __s1, const char* __s2, size_t __n)
+{ return ::memcmp(__s1, __s2, __n); }
+
typo here.
http://reviews.llvm.org/D11948
_
Ah, so we need a flag -fno-module-map-file-deps, I assume...
On Tue, Aug 11, 2015 at 8:12 PM Richard Smith wrote:
> On Tue, Aug 11, 2015 at 4:57 AM, Manuel Klimek wrote:
>
>> I believe this breaks -fno-module-file-deps.
>>
>
> I don't think so; this affects which module map files end up in the
On Tue, Aug 11, 2015 at 8:46 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Can't you just change your signature to
>
> virtual void a(int /* x */) {}
>
> in these cases?
>
You could - does it add much value to do that, though? (perhaps it does -
it means you express the
hiraditya abandoned this revision.
hiraditya added a comment.
Duplicate of:
http://reviews.llvm.org/D9924
http://reviews.llvm.org/D9741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:1018-1019
@@ -1017,2 +1017,4 @@
"expected ';' after module name">;
+def err_unexpected_module_end : Error<"unexpected module end">;
+def err_unexpected_module_start : Error<"submodule cannot b
Those files were parsed as part of building the output, and are legitimate
dependencies of the compilation process; why do you want to suppress them
from the .d file? (I think adding a whole bunch of -fno-*-deps flags is
going in the wrong direction, and would like to understand if there's some
hig
On Tue, Aug 11, 2015 at 8:38 PM Richard Smith wrote:
> Those files were parsed as part of building the output, and are legitimate
> dependencies of the compilation process; why do you want to suppress them
> from the .d file? (I think adding a whole bunch of -fno-*-deps flags is
> going in the wr
On Thu, Mar 19, 2015 at 5:00 AM, Manuel Klimek wrote:
> Author: klimek
> Date: Thu Mar 19 07:00:22 2015
> New Revision: 232721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=232721&view=rev
> Log:
> Add option to switch off putting header modules into the dependency file.
>
Why? It is not corr
joerg added a subscriber: joerg.
joerg added a comment.
I'm against doing this unconditionally. IMO it creates bugs without reasonable
compensation. Just because glibc wants to hurt people doesn't mean anyone
should get hurt.
http://reviews.llvm.org/D11948
__
danalbert added a comment.
In http://reviews.llvm.org/D11948#221936, @joerg wrote:
> I'm against doing this unconditionally. IMO it creates bugs without
> reasonable compensation. Just because glibc wants to hurt people doesn't mean
> anyone should get hurt.
+1. We don't want this in Android.
Back in the day I'm pretty sure you agreed with the general concept :)
http://reviews.llvm.org/D8378
I remember that we had problems with absolute paths ending up in the .d
file (which should not happen if none of the paths provided are absolute),
but I don't remember why we went for not writing th
On Tue, Aug 11, 2015 at 11:32 AM, David Blaikie wrote:
>
>
> On Tue, Aug 11, 2015 at 8:46 AM, Nico Weber via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Can't you just change your signature to
>>
>> virtual void a(int /* x */) {}
>>
>> in these cases?
>>
>
> You could - does it add
Prazek marked 4 inline comments as done.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:193-194
@@ -192,1 +192,4 @@
+ bool isVirtualOffsetNeeded(CodeGenFunction &CGF,
+ const CXXRecordDecl *NearestVBase) override;
+
isVirtualOffsetNeededF
Prazek marked 3 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D11859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 31846.
http://reviews.llvm.org/D11859
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGClass.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cpp
test/CodeGen/available-externally-hidden.cpp
test/CodeGenCXX/c
On Tue, Aug 11, 2015 at 11:49 AM, Manuel Klimek wrote:
> Back in the day I'm pretty sure you agreed with the general concept :)
>
Yeah, I don't think I fully understood the reason for having a cc1
-module-file-deps flag at the time.
http://reviews.llvm.org/D8378
> I remember that we had problem
mclow.lists added inline comments.
Comment at: include/cstring:96
@@ +95,3 @@
+int strncmp(const char* __s1, const char* __s2, size_t __n)
+{ return ::memcmp(__s1, __s2, __n); }
+
nlopes wrote:
> typo here.
Oops. Thanks!
http://reviews.llvm.org/D11948
___
mclow.lists added a comment.
In http://reviews.llvm.org/D11948#221936, @joerg wrote:
> I'm against doing this unconditionally. IMO it creates bugs without
> reasonable compensation. Just because glibc wants to hurt people doesn't mean
> anyone should get hurt.
Really? I see it as:
It tells
Author: majnemer
Date: Tue Aug 11 14:25:13 2015
New Revision: 244650
URL: http://llvm.org/viewvc/llvm-project?rev=244650&view=rev
Log:
[MSVC Compatibility] Classify ext_ms_cast_fn_obj as DefaultError
This non-conforming extension was introduced to make it possible for us
to correctly compile in
eliben added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5944
@@ -5943,3 +5943,3 @@
ProcessDeclAttributes(S, NewVD, D);
-
+ bool ShouldHandleTargetErrors = DeclAttrsMatchCUDAMode(getLangOpts(), NewVD);
if (getLangOpts().CUDA) {
Since this is a CUDA-o
joerg added a comment.
No, it doesn't. It tells the compiler that it is free to make such assumptions.
Take a step back from the standard. Can you think of any reasonable and
efficient implementation of memcpy and friends, which fails for size 0? Adding
the annotations (whether here or in strin
Prazek marked 4 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D11859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Aug 11, 2015 at 8:54 AM, Aaron Ballman
wrote:
> On Mon, Aug 10, 2015 at 3:00 PM, Nathan Wilson
> wrote:
> > nwilson created this revision.
> > nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin,
> faisalv, aaron.ballman.
> > nwilson added a subscriber: cfe-commits.
> >
On Tue, Aug 11, 2015 at 3:32 PM, Joerg Sonnenberger via cfe-commits
wrote:
> joerg added a comment.
>
> No, it doesn't. It tells the compiler that it is free to make such
> assumptions. Take a step back from the standard. Can you think of any
> reasonable and efficient implementation of memcpy a
On Tue, Aug 11, 2015 at 3:36 PM, Nathan Wilson wrote:
>
>
> On Tue, Aug 11, 2015 at 8:54 AM, Aaron Ballman
> wrote:
>>
>> On Mon, Aug 10, 2015 at 3:00 PM, Nathan Wilson
>> wrote:
>> > nwilson created this revision.
>> > nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin,
>> >
>
> Would you be opposed to annotations that tell the programmer they have
> UB in their code, but *do not* effect the code generation?
Not on our end. This would be great.
On Tue, Aug 11, 2015 at 12:56 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Aug 11, 201
On Tue, Aug 11, 2015 at 4:10 PM, Dan Albert wrote:
>> Would you be opposed to annotations that tell the programmer they have
>> UB in their code, but *do not* effect the code generation?
>
>
> Not on our end. This would be great.
I ask because the new nullability attributes do not affect codegen
JonChesterfield created this revision.
JonChesterfield added a subscriber: cfe-commits.
JonChesterfield set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
The clang-format option SpaceBeforeParens "Always" does not insert a space
before the opening parenthesis of
Author: dblaikie
Date: Tue Aug 11 15:21:45 2015
New Revision: 244658
URL: http://llvm.org/viewvc/llvm-project?rev=244658&view=rev
Log:
Revert the diagnostic improvements in r244602 as they introduced a problematic
dependency
Seems we had some internal uses that include ClangTidyTest.h and weren'
djasper added a subscriber: djasper.
djasper accepted this revision.
djasper added a reviewer: djasper.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access?
Repository:
rL LLVM
http://reviews.llvm.org/D11957
__
JonChesterfield added a comment.
Thanks. I have no commit access.
Repository:
rL LLVM
http://reviews.llvm.org/D11957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
In http://reviews.llvm.org/D11948#221991, @joerg wrote:
> No, it doesn't. It tells the compiler that it is free to make such
> assumptions.
Again, I disagree. The compiler already knows it is free to make such
assumptions.
(LLVM has an entire optimizer pass devote
rsmith added a comment.
This will be in 3.7.
Repository:
rL LLVM
http://reviews.llvm.org/D3583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg added a subscriber: joerg.
joerg added a comment.
I agree in principle. The "-static" thing is already in the initial code, but
doesn't make sense to me.
Comment at: lib/Driver/Tools.cpp:2928
@@ +2927,3 @@
+/// Parses the various -fpic/-fPIC/-fpie/-fPIE arguments. Then,
Author: djasper
Date: Tue Aug 11 15:32:24 2015
New Revision: 244660
URL: http://llvm.org/viewvc/llvm-project?rev=244660&view=rev
Log:
clang-format: Make SpaceBeforeParens work with overloaded operators.
Patch by Jon Chesterfield, thank you!
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
Hi,
thanks for the review, I was not even aware that this could be
tested. Adding a test helped to fix me a couple extra issues (plus the
one you already mentioned). New patch attached.
Xan
On Wed, Aug 05, 2015 at 09:14:30AM -0400, Rafael Espíndola wrote:
> Please git-clang-format this patch.
>
djasper closed this revision.
djasper added a comment.
Submitted as r244660. Thank you.
Repository:
rL LLVM
http://reviews.llvm.org/D11957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Yeah, those sound like exactly what we want. Helping people find UB is
good, but optimizing assuming we've fixed all of the UB isn't something we
can do. Our bugs end up being rather permanent so we need to be defensive.
On Tue, Aug 11, 2015 at 1:18 PM, Aaron Ballman
wrote:
> On Tue, Aug 11, 201
On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Thu Aug 6 15:56:55 2015
> New Revision: 244266
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244266&view=rev
> Log:
> [ItaniumCXXABI] Don't import RTTI data for classes with key functions
>
> MinGW
Author: aaronballman
Date: Tue Aug 11 15:42:00 2015
New Revision: 244662
URL: http://llvm.org/viewvc/llvm-project?rev=244662&view=rev
Log:
Add an AST matcher to match member intializers of a CXXCtorInitializer.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/include/clang/
joerg added a comment.
LLVM makes the assumptions only if the prototype has them too? Attribute
nonnull is certainly changing optimiser behavior with GCC...
http://reviews.llvm.org/D11948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
aprantl created this revision.
aprantl added reviewers: dblaikie, echristo.
aprantl added a subscriber: cfe-commits.
aprantl set the repository for this revision to rL LLVM.
This patch adds a -gmodules option to the driver and a -dwarf-ext-refs to cc1
to enable the use of external type references
strager added a comment.
ping
http://reviews.llvm.org/D10371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Aug 11, 2015 at 1:34 PM, Dan Albert wrote:
> Yeah, those sound like exactly what we want. Helping people find UB is
> good, but optimizing assuming we've fixed all of the UB isn't something we
> can do.
>
Dan -- that's the situation you're in today.
GCC has done that kind of optimization
- Original Message -
> From: "Marshall Clow via cfe-commits"
> To: "mclow lists" , chandl...@gmail.com,
> rich...@metafoo.co.uk, e...@efcs.ca
> Cc: jo...@netbsd.org, cfe-commits@lists.llvm.org
> Sent: Tuesday, August 11, 2015 3:30:10 PM
> Subject: Re: [PATCH] D11948: Add some macros to ab
rsmith added a comment.
Reid, do you remember what this FIXME was for? (Added in r198462.)
http://reviews.llvm.org/D11928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Tue Aug 11 16:09:52 2015
New Revision: 244666
URL: http://llvm.org/viewvc/llvm-project?rev=244666&view=rev
Log:
Add a polymorphic AST matcher for testing whether a constructor or a conversion
declaration is marked as explicit or not.
Modified:
cfe/trunk/docs/LibAST
1 - 100 of 156 matches
Mail list logo
