r244437 - [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel

Author: john.brawn Date: Mon Aug 10 06:11:28 2015 New Revision: 244437 URL: http://llvm.org/viewvc/llvm-project?rev=244437&view=rev Log: [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel -mkernel enables -fno-builtin and -fno-common by default, but allows -fbuiltin and -fcom

Re: [PATCH] D11459: [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel

This revision was automatically updated to reflect the committed changes. Closed by commit rL244437: [Driver] Fix handling of -fbuiltin/-fcommon when combined with -mkernel (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D11459?vs=30478&id=31648#toc Repository: rL

Re: [PATCH] D11837: Add Qt brace style configuration option.

lifted added a comment. Hooray, I've found the style I need - it's WebKit https://www.webkit.org/coding/coding-style.html So I believe there are other people waiting for the same style as me - https://code.google.com/p/chromium/issues/detail?id=454958 How do you feel about renaming `BS_Qt` -> `

Re: [PATCH] D11837: Add Qt brace style configuration option.

klimek added a comment. Webkit doesn't break for classes: class MyClass { ... }; http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11837: Add Qt brace style configuration option.

lifted added a comment. In http://reviews.llvm.org/D11837#220394, @klimek wrote: > Webkit doesn't break for classes: That's why we need to revert changes in UnwrappedLineParser.cpp. The funny thing with WebKit style is that we don't need to add any logic to deal with it, any style different fr

Re: [PATCH] D11837: Add Qt brace style configuration option.

klimek added a comment. Ah, ok. Interestingly, our current Webkit style uses BS_Stroustrup, which is incorrect for } else {. So yep, implementing BS_Webkit sounds like a win. http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D11837: Add Qt brace style configuration option.

lifted updated this revision to Diff 31660. lifted added a comment. Removed Qt brace style, add WebKit brace style. Changed default brace style in the WebKit configuration to BS_WebKit. http://reviews.llvm.org/D11837 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h l

Re: [PATCH] D11837: Add WebKit brace style configuration option.

klimek added a comment. Can you also fix the current code in getWebKitStyle? http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11837: Add WebKit brace style configuration option.

lifted added a comment. In http://reviews.llvm.org/D11837#220408, @klimek wrote: > Can you also fix the current code in getWebKitStyle? Yep, I've already done it. http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D11837: Add WebKit brace style configuration option.

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. Ah, awesome, looks good then. Do you have commit access or need one of us to land it? http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D11837: Add WebKit brace style configuration option.

lifted added a comment. I had commit access earlier, but I haven't tried it for long time. I'll ask for help if there are any problems. http://reviews.llvm.org/D11837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

r244446 - Add WebKit brace style configuration option.

Author: lifted Date: Mon Aug 10 08:43:19 2015 New Revision: 26 URL: http://llvm.org/viewvc/llvm-project?rev=26&view=rev Log: Add WebKit brace style configuration option. Summary: Add brace style `BS_WebKit` as described on https://www.webkit.org/coding/coding-style.html: * Function defi

Re: [PATCH] D11837: Add WebKit brace style configuration option.

This revision was automatically updated to reflect the committed changes. Closed by commit rL26: Add WebKit brace style configuration option. (authored by lifted). Changed prior to commit: http://reviews.llvm.org/D11837?vs=31660&id=31665#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D10305: [Clang Static Analyzer] Bug identification

honggyu.kim added a comment. Hi Babati, I'm sorry for the late appreciation response. I can see the Bug ID in HTML. I have also tested CmpRuns.py and it works also fine as Anna explained. CmpRuns.py works great with plist files, but I personally want to compare two reports with HTML results with

Re: [PATCH] D11781: Refactored pthread usage in libcxx

On 8/8/15 2:23 PM, Fulvio Esposito wrote: espositofulvio added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__linux__) || defined(__APPLE__) +# define _LIBCPP_THREAD_

Re: [PATCH] D11240: Add basic #include sorting functionality to clang-format

djasper updated this revision to Diff 31670. djasper added a comment. Added an alternative way to handle the two sets of Replacements: Merge them properly. I haven't completely finished implementing / testing this. Wanted to get feedback first before going further down this road. http://revie

Re: [PATCH] D11781: Refactored pthread usage in libcxx

ed added a subscriber: ed. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__linux__) || defined(__APPLE__) +# define _LIBCPP_THREAD_API _LIBCPP_PTHREAD espositofulvio wro

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: tools/driver/driver.cpp:464-466 @@ +463,5 @@ + PrependedOpts); + // Insert right after the program name to prepend to

[clang-tools-extra] r244454 - misc-unused-parameters: Don't touch K&R style functions.

Author: djasper Date: Mon Aug 10 10:45:46 2015 New Revision: 244454 URL: http://llvm.org/viewvc/llvm-project?rev=244454&view=rev Log: misc-unused-parameters: Don't touch K&R style functions. We couldn't calculate the removal ranges properly at this point. Added: clang-tools-extra/trunk/test/

Re: [PATCH] D11781: Refactored pthread usage in libcxx

ed added a comment. A general note I have regarding this change: Now that we're introducing separate implementations for mutexes and condition variables, could we also consider letting `shared_mutex` and friends simply use `pthread_rwlock_*()`? We currently have it implemented as a wrapper on t

Re: [PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

EricWF added a comment. In http://reviews.llvm.org/D11682#216902, @jroelofs wrote: > Does this install the headers too? No. Just the libraries. http://reviews.llvm.org/D11682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Fwd: [PATCH] D11906: Clang support for -fthinlto.

Forwarding manually, since it appears when I manually added reviewers (Rafael and Duncan) and cfe-commits as the subscriber in Phab, it only sent email to Rafael. Thanks, Teresa -- Forwarded message -- From: Teresa Johnson Date: Mon, Aug 10, 2015 at 8:58 AM Subject: [PATCH] D1190

Re: [PATCH] D11906: Clang support for -fthinlto.

Instead of forwarding this patch, which kills mail threading, I'd just abandon the patch and create a new one where you directly add llvm-commits when you upload it. (we know this is a problem, and we know how to fix it, but we'd need some php hackers to help) On Mon, Aug 10, 2015 at 6:14 PM Tere

Re: [PATCH] D11906: Clang support for -fthinlto.

tejohnson abandoned this revision. tejohnson added a comment. Abandoning as per klimek, need to add cfe-commit as subscriber during upload. http://reviews.llvm.org/D11906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

hans added a subscriber: hans. hans accepted this revision. hans added a reviewer: hans. hans added a comment. Out of curiosity, did you run in to something that relies on this in the wild? Comment at: tools/driver/driver.cpp:452 @@ +451,3 @@ +// The first instance of '#' sh

[PATCH] D11908: Clang support for -fthinlto.

tejohnson created this revision. tejohnson added reviewers: rafael, dexonsmith. tejohnson added a subscriber: cfe-commits. Add clang support for -fthinlto option, which is used to set the EmitThinLTOIndex code gen option on compiles, and the thinlto gold plugin option on links. Dependent on LLVM/

Re: [PATCH] D11781: Refactored pthread usage in libcxx

theraven added a comment. It would be nice to use rwlocks, but that's an ABI-breaking change. We'd need to bump the .so version and other annoyances. Definitely something I'd be in favour of seeing hidden behind some #ifdefs (and enabled for FreeBSD 11 and probably for the libc++ in packages)

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman added a comment. Ping? FWIW, this patch almost caught a bug in LLVM. ;-) DependenceAnalysis.h has a class: FullDependence which would suffer from this problem if the Dependence base class did not accidentally suppress creation of the move constructor by defaulting only the copy c

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

rnk added inline comments. Comment at: tools/driver/driver.cpp:451 @@ +450,3 @@ + if (Tokenizer == &llvm::cl::TokenizeWindowsCommandLine) { +// The first instance of '#' should be replaced with '='. +auto AdjustOpt = [] (const char *Opt) { I'd also rather

[libcxx] r244462 - Protect template argument from user interference.

Author: joerg Date: Mon Aug 10 11:58:04 2015 New Revision: 244462 URL: http://llvm.org/viewvc/llvm-project?rev=244462&view=rev Log: Protect template argument from user interference. Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type_traits URL: http://llvm.org/vi

r244467 - Add new llvm.loop.unroll.enable metadata for use with "#pragma unroll".

Author: meheff Date: Mon Aug 10 12:29:39 2015 New Revision: 244467 URL: http://llvm.org/viewvc/llvm-project?rev=244467&view=rev Log: Add new llvm.loop.unroll.enable metadata for use with "#pragma unroll". This change adds the new unroll metadata "llvm.loop.unroll.enable" which directs the optimiz

Re: [PATCH] D11738: Add new llvm.loop.unroll.enable metadata which is now generated by "#pragma unroll" directive

meheff closed this revision. meheff added a comment. Thanks! http://reviews.llvm.org/D11738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244468 - Correct x86_64 fp128 calling convention

Author: chh Date: Mon Aug 10 12:33:31 2015 New Revision: 244468 URL: http://llvm.org/viewvc/llvm-project?rev=244468&view=rev Log: Correct x86_64 fp128 calling convention These changes are for Android x86_64 targets to be compatible with current Android g++ and conform to AMD64 ABI. https://llvm.

Re: [PATCH] D11437: Correct x86_64 fp128 calling convention

This revision was automatically updated to reflect the committed changes. Closed by commit rL244468: Correct x86_64 fp128 calling convention (authored by chh). Changed prior to commit: http://reviews.llvm.org/D11437?vs=31457&id=31687#toc Repository: rL LLVM http://reviews.llvm.org/D11437 F

Re: r244070 - [CMake] First pass at adding support for clang bootstrap builds to CMake

> On Aug 5, 2015, at 3:15 PM, Justin Bogner wrote: > > > Chris Bieneman writes: >> Author: cbieneman >> Date: Wed Aug 5 12:38:12 2015 >> New Revision: 244070 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244070&view=rev >> Log: >> [CMake] First pass at adding support for clang bootstrap

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Mon Aug 10 11:58:04 2015 > New Revision: 244462 > > URL: http://llvm.org/viewvc/llvm-project?rev=244462&view=rev > Log: > Protect template argument from user interference. Hi Marshall, Han

Re: [libcxx] r244462 - Protect template argument from user interference.

On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits wrote: > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via cfe-commits > wrote: >> Author: joerg >> Date: Mon Aug 10 11:58:04 2015 >> New Revision: 244462 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244462&

Re: [PATCH] D11896: [clang-cl] Add support for CL and _CL_ environment variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL244473: [clang-cl] Add support for CL and _CL_ environment variables (authored by majnemer). Changed prior to commit: http://reviews.llvm.org/D11896?vs=31640&id=31695#toc Repository: rL LLVM http://

r244473 - [clang-cl] Add support for CL and _CL_ environment variables

Author: majnemer Date: Mon Aug 10 13:16:32 2015 New Revision: 244473 URL: http://llvm.org/viewvc/llvm-project?rev=244473&view=rev Log: [clang-cl] Add support for CL and _CL_ environment variables cl uses 'CL' and '_CL_' to prepend and append command line options to the given argument vector. The

Re: [PATCH] D11737: Add -linker (and -linker=) alias for -fuse-ld=

filcab updated this revision to Diff 31693. filcab added a comment. Update to latest trunk. Ping. http://reviews.llvm.org/D11737 Files: include/clang/Driver/Options.td test/Driver/fuse-ld.c Index: test/Driver/fuse-ld.c === ---

Re: [libcxx] r244462 - Protect template argument from user interference.

This is my mistake and I would like to see it merged. On Aug 10, 2015 2:13 PM, "Hans Wennborg via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > On Mon, Aug 10, 2015 at 11:09 AM, Joerg Sonnenberger via cfe-commits > wrote: > > On Mon, Aug 10, 2015 at 04:58:04PM -, Joerg Sonnenberger via

[PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

rnk created this revision. rnk added reviewers: majnemer, hans. rnk added a subscriber: cfe-commits. The vtable takes its DLL storage class from the class, not the key function. When they disagree, the vtable won't be exported by the DLL that defines the key function. The easiest way to ensure tha

Re: [PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D11913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified

nwilson created this revision. nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin, faisalv, aaron.ballman. nwilson added a subscriber: cfe-commits. Adding check to emit diagnostic for invalid tag when concept is specified and associated tests. http://reviews.llvm.org/D11916

Re: [PATCH] D10365: Add cmd to compilation database file format

diltsman added a subscriber: diltsman. diltsman added a comment. I'm trying to upload a new patch and I get an error from Phabricator: 'Unhandled Exception ("Exception")'. Any ideas how to get this to work? I have attached the diff file. - F722854: Arguments.patch

Re: [PATCH] D11859: Generating vptr assume loads

majnemer added a comment. Some first round review comments. Comment at: lib/CodeGen/CGClass.cpp:1831-1832 @@ +1830,4 @@ + + // generate vtable assumptions if we are not in another ctor and + // if we calling dynamic class ctor + if (CGM.getCodeGenOpts().OptimizationLevel > 0

Re: [PATCH] D11658: [Sema] main can't be declared as global variable

On Thu, Jul 30, 2015 at 07:01:22PM +, Davide Italiano wrote: > Index: test/CXX/basic/basic.start/basic.start.main/p3.cpp > === > --- test/CXX/basic/basic.start/basic.start.main/p3.cpp > +++ test/CXX/basic/basic.start/basic.start.ma

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1842 @@ +1841,3 @@ + CGM.getCXXABI().getVTableAddressPoint(vptr.Base, vptr.VTableClass); + if (!VTableGlobal) return; + majnemer wrote: > The return should be on it's own line, please clang-fo

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: include/clang/AST/VTableBuilder.h:387-391 @@ -386,7 +386,3 @@ - // Copy constructor. - // FIXME: Uncomment when we've moved to C++11. - // VPtrInfo(const VPtrInfo &) = default; - /// The vtable will hold all of the virtual bases or

Re: [PATCH] D11859: Generating vptr assume loads

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2098 @@ -2063,3 +2097,3 @@ // Initialize the vtable pointer for this base. -InitializeVTablePointer(Base, NearestVBase, OffsetFromNearestVBase, -VTableClass); +VPtr vptr{Base

Re: [PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

This revision was automatically updated to reflect the committed changes. Closed by commit rL244488: [dllimport] A non-imported class with an imported key can't have a key (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D11913?vs=31697&id=31710#toc Repository: rL LLVM ht

r244488 - [dllimport] A non-imported class with an imported key can't have a key

Author: rnk Date: Mon Aug 10 14:39:01 2015 New Revision: 244488 URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev Log: [dllimport] A non-imported class with an imported key can't have a key Summary: The vtable takes its DLL storage class from the class, not the key function. When they

Re: r243851 - Fix invalid shufflevector operands

On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim wrote: > On 06/08/2015 18:05, Hans Wennborg wrote: >> >> On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim >> wrote: >>> >>> Author: rksimon >>> Date: Sun Aug 2 10:28:10 2015 >>> New Revision: 243851 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=

Re: r244468 - Correct x86_64 fp128 calling convention

On Mon, Aug 10, 2015 at 10:33 AM, Chih-Hung Hsieh via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chh > Date: Mon Aug 10 12:33:31 2015 > New Revision: 244468 > > URL: http://llvm.org/viewvc/llvm-project?rev=244468&view=rev > Log: > Correct x86_64 fp128 calling convention > > These c

r244490 - Fix typo.

Author: nicholas Date: Mon Aug 10 14:54:11 2015 New Revision: 244490 URL: http://llvm.org/viewvc/llvm-project?rev=244490&view=rev Log: Fix typo. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

r244492 - Append options for floating-point commutivity when related diagnostics are produced.

Author: tnowicki Date: Mon Aug 10 14:56:40 2015 New Revision: 244492 URL: http://llvm.org/viewvc/llvm-project?rev=244492&view=rev Log: Append options for floating-point commutivity when related diagnostics are produced. With this patch clang appends the command line options that would allow vec

Re: r244492 - Append options for floating-point commutivity when related diagnostics are produced.

On Mon, Aug 10, 2015 at 3:56 PM, Tyler Nowicki via cfe-commits wrote: > Author: tnowicki > Date: Mon Aug 10 14:56:40 2015 > New Revision: 244492 > > URL: http://llvm.org/viewvc/llvm-project?rev=244492&view=rev > Log: > Append options for floating-point commutivity when related diagnostics are > p

<    1   2