Re: r374841 - [Modules][PCH] Hash input files content

2019-10-14 Thread Bruno Cardoso Lopes via cfe-commits
Thanks Eric! On Mon, Oct 14, 2019 at 8:12 PM Eric Christopher wrote: > > This was breaking a few bots and I couldn't find you on irc so I've > reverted it thusly: > > echristo@jhereg ~/s/llvm-project> git llvm push > Pushing 1 commit: > 175b1b856ea Temporarily Revert [Modules][PCH] Hash input f

Re: r374841 - [Modules][PCH] Hash input files content

2019-10-14 Thread Eric Christopher via cfe-commits
This was breaking a few bots and I couldn't find you on irc so I've reverted it thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 175b1b856ea Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. Sendingcfe/trunk/include/clang/Bas

r374841 - [Modules][PCH] Hash input files content

2019-10-14 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Mon Oct 14 16:02:03 2019 New Revision: 374841 URL: http://llvm.org/viewvc/llvm-project?rev=374841&view=rev Log: [Modules][PCH] Hash input files content Summary: When files often get touched during builds, the mtime based validation leads to different problems in implicit modul