Thanks, Jan. And one more time, sorry about the inconvenience.
On Thu, Oct 10, 2019 at 12:47 AM Jan Korous wrote:
> Ok, no worries. I understand the reason for the revert and will rewrite
> the patch.
>
>
> On Oct 9, 2019, at 7:19 AM, Ilya Biryukov wrote:
>
> Fair enough, sorry about that.
>
>
Ok, no worries. I understand the reason for the revert and will rewrite the
patch.
> On Oct 9, 2019, at 7:19 AM, Ilya Biryukov wrote:
>
> Fair enough, sorry about that.
>
> Nevertheless, I wanted to re-raise concerns about the approach taken in the
> patch. It seems to assume invariants abou
Fair enough, sorry about that.
Nevertheless, I wanted to re-raise concerns about the approach taken in the
patch. It seems to assume invariants about VFS that don't necessarily hold
for filesystems outside those tested in upstream LLVM.
PTAL at the original patch - calling `getRealPath` on the FS
FWIW reverting a patch for it breaking some internal system seems like poor
form to me. It's really hard to reland in that case. Please make a reduced
repro next time.
On Wed, Oct 9, 2019 at 5:38 AM Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Reverted in r374151.
>
> On W
Reverted in r374151.
On Wed, Oct 9, 2019 at 11:03 AM Ilya Biryukov wrote:
> Hi Jan,
>
> This patch seems to assume VFS will only re-map some paths, but still
> point into the physical filesystem.
> This may not be the case, e.g. in unit tests.
>
> This also manages to break some of our internal
Author: ibiryukov
Date: Wed Oct 9 02:40:22 2019
New Revision: 374151
URL: http://llvm.org/viewvc/llvm-project?rev=374151&view=rev
Log:
Revert r374006: Reland 'Add VFS support for sanitizers' blacklist'
Also revert follow-up changes to the test.
Reason: the patch breaks our
Hi Jan,
This patch seems to assume VFS will only re-map some paths, but still point
into the physical filesystem.
This may not be the case, e.g. in unit tests.
This also manages to break some of our internal clang-tidy integrations for
obscure reasons.
Can we instead just pass VFS instance to th
Author: jkorous
Date: Mon Oct 7 18:13:17 2019
New Revision: 374006
URL: http://llvm.org/viewvc/llvm-project?rev=374006&view=rev
Log:
Reland 'Add VFS support for sanitizers' blacklist'
The original patch broke the test for Windows.
Trying to fix as per Reid's suggestions outlined here:
https://re
