Re: r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

2019-10-01 Thread Dávid Bolvanský via cfe-commits
I fixed it, forgot to run clang semacxx check too. I am not sure.. I checked github and found case: https://github.com/ros-industrial-consortium/godel/issues/115 Seems like this is very rare, not worth to make it on.. ut 1. 10. 2019 o 20:19 Nico Weber napísal(a): > > This breaks emaCXX/warn-sig

Re: r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

2019-10-01 Thread Nico Weber via cfe-commits
This breaks emaCXX/warn-sign-conversion.cpp -- but see other thread, maybe just revert this for now until we know what we want to do here :) On Tue, Oct 1, 2019 at 2:10 PM David Bolvansky via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xbolva00 > Date: Tue Oct 1 11:12:13 2019 > Ne

r373371 - [Diagnostics] Make -Wenum-compare-conditional off by default

2019-10-01 Thread David Bolvansky via cfe-commits
Author: xbolva00 Date: Tue Oct 1 11:12:13 2019 New Revision: 373371 URL: http://llvm.org/viewvc/llvm-project?rev=373371&view=rev Log: [Diagnostics] Make -Wenum-compare-conditional off by default Too many false positives, eg. in Chromium. Modified: cfe/trunk/include/clang/Basic/DiagnosticGro