Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

2019-09-05 Thread David Blaikie via cfe-commits
On Thu, Sep 5, 2019 at 9:57 AM Duncan P. N. Exon Smith wrote: > > > On Sep 4, 2019, at 17:39, David Blaikie wrote: > > > > On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dexonsmith >> Date: Mon Aug 26 11:29:51 2019 >>

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

2019-09-05 Thread Duncan P. N. Exon Smith via cfe-commits
> On Sep 4, 2019, at 17:39, David Blaikie wrote: > > > > On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: dexonsmith > Date: Mon Aug 26 11:29:51 2019 > New Revision: 369943 > > URL: http://llvm.org/viewvc/llvm-pr

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

2019-09-04 Thread David Blaikie via cfe-commits
On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dexonsmith > Date: Mon Aug 26 11:29:51 2019 > New Revision: 369943 > > URL: http://llvm.org/viewvc/llvm-project?rev=369943&view=rev > Log: > FileManager: Use llvm::Expected in ne

r369943 - FileManager: Use llvm::Expected in new getFileRef API

2019-08-26 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Mon Aug 26 11:29:51 2019 New Revision: 369943 URL: http://llvm.org/viewvc/llvm-project?rev=369943&view=rev Log: FileManager: Use llvm::Expected in new getFileRef API `FileManager::getFileRef` is a modern API which we expect to convert to over time. We should modernize th