Thanks!
On Mon, Aug 12, 2019 at 5:37 PM Alex L wrote:
> Hi Reid,
>
> I have fixed this issue in r368640, clang-scan-deps will no longer spawn
> threads if threading if disabled.
>
> Cheers,
> Alex
>
>
> On Thu, 8 Aug 2019 at 15:13, Alex L wrote:
>
>> Thanks for fixing this!
>>
>> I think changi
Hi Reid,
I have fixed this issue in r368640, clang-scan-deps will no longer spawn
threads if threading if disabled.
Cheers,
Alex
On Thu, 8 Aug 2019 at 15:13, Alex L wrote:
> Thanks for fixing this!
>
> I think changing clang-scan-deps to ignore -j when `LLVM_ENABLE_THREADS`
> is probably a be
Thanks for fixing this!
I think changing clang-scan-deps to ignore -j when `LLVM_ENABLE_THREADS` is
probably a better solution. I'll work on a patch that does that.
On Thu, 8 Aug 2019 at 15:07, Reid Kleckner wrote:
> The specific issue here is that clang-scan-deps uses threads, which seems
>
The specific issue here is that clang-scan-deps uses threads, which seems
to work just fine. But, it calls some code that sets up PrettyStackTrace
RAII objects, which normally use TLS. And when LLVM_ENABLE_THREADS is off,
LLVM_THREAD_LOCAL expands to nothing, so the TLS variables are simply
global,
Author: rnk
Date: Thu Aug 8 14:45:59 2019
New Revision: 368354
URL: http://llvm.org/viewvc/llvm-project?rev=368354&view=rev
Log:
Mark clang-scan-deps test as requiring thread support
Otherwise the test calls a pure virtual method and crashes. Perhaps this
could be improved.
Modified:
cfe/tr
