Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

2019-08-05 Thread Nico Weber via cfe-commits
There was yet another uninit read: Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. FAIL: Clang-Unit :: CrossTU/./CrossTUTests/CrossTranslationUnit.RespectsLoadThreshold (13891 of 15323) TEST 'Clang-Unit :: CrossTU/./CrossTUTests/CrossTranslationUnit.

Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

2019-08-05 Thread Nico Weber via cfe-commits
The problem is probably this part from the diff: - unsigned NumASTLoaded{0u}; + + /// The number successfully loaded ASTs. Used to indicate, and - with the + /// appropriate threshold value - limit the memory usage of the + /// CrossTranslationUnitContext. + unsigned NumASTLoaded; i.e. yo

Re: r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

2019-08-05 Thread Nico Weber via cfe-commits
The msan bot doesn't like this, it reports an uninitialized read a t clang/lib/CrossTU/CrossTranslationUnit.cpp : http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/34087/steps/check-clang%20msan/logs/stdio Testing: 0 FAIL: Clang :: Analysis/ctu-unknown-part

r367829 - [CrossTU][NFCI] Refactor loadExternalAST function

2019-08-05 Thread Endre Fulop via cfe-commits
Author: gamesh411 Date: Mon Aug 5 04:06:41 2019 New Revision: 367829 URL: http://llvm.org/viewvc/llvm-project?rev=367829&view=rev Log: [CrossTU][NFCI] Refactor loadExternalAST function Summary: Refactor loadExternalAST method of CrossTranslationUnitContext in order to reduce maintenance burden a