Makes sense, thanks. Seems like INTERFACE is the way to go then.
From: on behalf of Chris Bieneman
Date: Tuesday, July 16, 2019 at 10:32 AM
To: Shoaib Meenai
Cc: Alex Bradbury , cfe-commits
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
I get that CMake does
on behalf of Chris Bieneman
> Date: Friday, July 12, 2019 at 9:08 AM
> To: Shoaib Meenai
> Cc: Alex Bradbury , cfe-commits
> Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
>
> Ah! I see what is going on here. This is kinda a silliness of CMake.
Chris Bieneman
Date: Friday, July 12, 2019 at 9:08 AM
To: Shoaib Meenai
Cc: Alex Bradbury , cfe-commits
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
Ah! I see what is going on here. This is kinda a silliness of CMake. `PRIVATE`
linkage for a static archive is
Reverted in r365922.
From: on behalf of Chris Bieneman
Date: Friday, July 12, 2019 at 9:08 AM
To: Shoaib Meenai
Cc: Alex Bradbury , cfe-commits
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
Ah! I see what is going on here. This is kinda a silliness of CMake
Meenai
Cc: Alex Bradbury , cfe-commits
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
Ah! I see what is going on here. This is kinda a silliness of CMake. `PRIVATE`
linkage for a static archive is silly, and shouldn't be possible. All link
dependencies for s
; To: Shoaib Meenai
> Cc: Alex Bradbury , cfe-commits
> Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
>
> One of the benefits of the object library approach for generating the clang
> dylib is that it was compatible with BUILD_SHARED_LIBS. We had lots of
, 2019 at 8:49 AM
To: Shoaib Meenai
Cc: Alex Bradbury , cfe-commits
Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
One of the benefits of the object library approach for generating the clang
dylib is that it was compatible with BUILD_SHARED_LIBS. We had lots of
> Should we disable building the latter if the former is set?
>
> From: Alex Bradbury
> Date: Friday, July 12, 2019 at 2:02 AM
> To: Shoaib Meenai
> Cc: cfe-commits
> Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies
>
> On Thu, 11 J
clang-shlib] Fix clang-shlib for PRIVATE dependencies
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
Author: smeenai
Date: Thu Jul 11 14:20:38 2019
New Revision: 365825
URL:
https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits
wrote:
>
> Author: smeenai
> Date: Thu Jul 11 14:20:38 2019
> New Revision: 365825
>
> URL: http://llvm.org/viewvc/llvm-project?rev=365825&view=rev
> Log:
> [clang-shlib] Fix clang-shlib for PRIVATE dependencies
>
> Any static library wit
Author: smeenai
Date: Thu Jul 11 14:20:38 2019
New Revision: 365825
URL: http://llvm.org/viewvc/llvm-project?rev=365825&view=rev
Log:
[clang-shlib] Fix clang-shlib for PRIVATE dependencies
Any static library with a PRIVATE dependency ends up with a
$ generator expression in its INTERFACE_LINK_LIB
11 matches
Mail list logo
