Re: r365724 - clang-cl: Remove -O0 option

2019-07-12 Thread Nico Weber via cfe-commits
Looks like you didn't add UNSUPPORTED and went for the right fix immediately in https://reviews.llvm.org/D64587. Thanks for taking care of this! On Thu, Jul 11, 2019 at 4:04 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This seems to have caused a libfuzzer test to fail

Re: r365724 - clang-cl: Remove -O0 option

2019-07-11 Thread Reid Kleckner via cfe-commits
This seems to have caused a libfuzzer test to fail here: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/48261 It's not easy to fix because -O0 is passed to clang-cl on Windows and clang elsewhere, so /Od won't do the trick without a substitution. This was kind of why I added -O0 in the

r365724 - clang-cl: Remove -O0 option

2019-07-10 Thread Nico Weber via cfe-commits
Author: nico Date: Wed Jul 10 18:18:05 2019 New Revision: 365724 URL: http://llvm.org/viewvc/llvm-project?rev=365724&view=rev Log: clang-cl: Remove -O0 option cl.exe doesn't understand it; there's /Od instead. See also the review thread for r229575. Update lots of compiler-rt tests to use -Od in