Re: r360946 - Add Clang shared library with C++ exports

2019-05-17 Thread Nico Weber via cfe-commits
Thanks! Bots are happy with the reland. Thanks for taking the time to explain the object library stuff! *From: *Chris Bieneman *Date: *Thu, May 16, 2019 at 11:24 PM *To: *Nico Weber *Cc: *cfe-commits I’ll re-land disabling if PIC is off. > > This doesn’t replace the static libraries with object

Re: r360946 - Add Clang shared library with C++ exports

2019-05-16 Thread Chris Bieneman via cfe-commits
I’ll re-land disabling if PIC is off. This doesn’t replace the static libraries with object libraries, it just creates an object library target (named obj.${name}) for each static library. That allows the objects to be referenced separately from the archives, so we don’t have to do the -load-al

Re: r360946 - Add Clang shared library with C++ exports

2019-05-16 Thread Nico Weber via cfe-commits
To not keep the build broken over night, and since it's a small change that should be easy to reland, I've reverted this for now in r360973. On Thu, May 16, 2019 at 8:52 PM Nico Weber wrote: > Hello, > > this breaks building with -DLLVM_ENABLE_PIC=OFF. Maybe the new target > shouldn't be build i

r360973 - Revert r360946 "Add Clang shared library with C++ exports"

2019-05-16 Thread Nico Weber via cfe-commits
Author: nico Date: Thu May 16 18:42:37 2019 New Revision: 360973 URL: http://llvm.org/viewvc/llvm-project?rev=360973&view=rev Log: Revert r360946 "Add Clang shared library with C++ exports" It breaks LLVM_ENABLE_PIC=OFF builds, and it's not clear if the object library approach

Re: r360946 - Add Clang shared library with C++ exports

2019-05-16 Thread Nico Weber via cfe-commits
Hello, this breaks building with -DLLVM_ENABLE_PIC=OFF. Maybe the new target shouldn't be build in those builds? Also, if I read this right, this makes static libraries for clang always be object libraries. Is that correct? If so, this likely makes the normal clang binary larger and less efficie

r360946 - Add Clang shared library with C++ exports

2019-05-16 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Thu May 16 15:06:07 2019 New Revision: 360946 URL: http://llvm.org/viewvc/llvm-project?rev=360946&view=rev Log: Add Clang shared library with C++ exports Summary: This patch adds a libClang_shared library on *nix systems which exports the entire C++ API. In order to suppo