*From: *Richard Smith
*Date: *Wed, May 15, 2019 at 5:43 PM
> On Wed, 15 May 2019 at 15:54, Reid Kleckner via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> We could probably re-land Richard's change (although it's quite a lot of
>> code...), but... drop the conflicting `static` on the fl
On Wed, 15 May 2019 at 15:54, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> *From: *Hans Wennborg
> *Date: *Wed, May 15, 2019 at 1:22 AM
>
>> On Tue, May 14, 2019 at 6:35 PM Richard Smith
>> wrote:
>> > Yep, I'm not at all surprised. Perhaps we should stop claiming to
>> s
*From: *Hans Wennborg
*Date: *Wed, May 15, 2019 at 1:22 AM
> On Tue, May 14, 2019 at 6:35 PM Richard Smith
> wrote:
> > Yep, I'm not at all surprised. Perhaps we should stop claiming to
> support this extension, given that it fundamentally violates assumptions
> made by clang (that linkage doesn
On Tue, May 14, 2019 at 6:35 PM Richard Smith wrote:
>
> On Tue, 14 May 2019, 03:09 Hans Wennborg via cfe-commits,
> wrote:
>>
>> Actually, we didn't notice r359260 in Chromium, however this one
>> (r360637) caused Clang to start asserting during our builds
>> (https://bugs.chromium.org/p/chromi
On Tue, 14 May 2019, 03:09 Hans Wennborg via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Actually, we didn't notice r359260 in Chromium, however this one
> (r360637) caused Clang to start asserting during our builds
> (https://bugs.chromium.org/p/chromium/issues/detail?id=962840), here's
>
Actually, we didn't notice r359260 in Chromium, however this one
(r360637) caused Clang to start asserting during our builds
(https://bugs.chromium.org/p/chromium/issues/detail?id=962840), here's
a reduced test case:
--
extern int a;
static int *use1 = &a;
int **use2 = &use1;
static int a = 0;
--
Author: hans
Date: Tue May 14 03:11:33 2019
New Revision: 360657
URL: http://llvm.org/viewvc/llvm-project?rev=360657&view=rev
Log:
Revert r360637 "PR41817: Fix regression in r359260 that caused the MS
compatibility"
> extension allowing a "static" declaration to follo
Author: rsmith
Date: Mon May 13 17:27:16 2019
New Revision: 360637
URL: http://llvm.org/viewvc/llvm-project?rev=360637&view=rev
Log:
PR41817: Fix regression in r359260 that caused the MS compatibility
extension allowing a "static" declaration to follow an "extern"
declaration to stop working.
Add
