Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

2019-05-13 Thread Richard Smith via cfe-commits
Thanks for the revert and the reduced test case. On Mon, 13 May 2019, 07:50 Hans Wennborg via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > Here's a creduced repro: > > -- > class a {}; > class b : virtual a { > virtual bool c(const void *, int); > }; > class C : b { > public: > bool c(

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

2019-05-13 Thread Hans Wennborg via cfe-commits
Here's a creduced repro: -- class a {}; class b : virtual a { virtual bool c(const void *, int); }; class C : b { public: bool c(const void *, int); }; int d; bool e() { C f; if (f.c(&d, d)) ; } -- $ clang.bad -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -std=c++14 a.cc The as

Re: r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

2019-05-13 Thread Hans Wennborg via cfe-commits
This caused asserts in Chromium, so I've reverted in r360580. There's a repro at https://bugs.chromium.org/p/chromium/issues/detail?id=962458#c1, and I'm working on a reduced version. From: Richard Smith via cfe-commits Date: Mon, May 13, 2019 at 9:39 AM To: > Author: rsmith > Date: Mon May 13

r360580 - Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant expression evaluation."

2019-05-13 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon May 13 06:19:09 2019 New Revision: 360580 URL: http://llvm.org/viewvc/llvm-project?rev=360580&view=rev Log: Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant expression evaluation." This caused Chromium builds to hit the new "c

r360559 - [c++20] P1064R0: Allow virtual function calls in constant expression

2019-05-13 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon May 13 00:42:10 2019 New Revision: 360559 URL: http://llvm.org/viewvc/llvm-project?rev=360559&view=rev Log: [c++20] P1064R0: Allow virtual function calls in constant expression evaluation. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/include/clang/Bas