Re: r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

2019-05-09 Thread Roman Lebedev via cfe-commits
... and i had to revert this & the other commit. Sorry :( This implementation isn't sound as per the standard. It erroneously diagnoses e.g. the following case: ``` $ cat test.cpp void f(int n) { #pragma omp parallel default(none) if(n) ; } ``` ``` $ ./bin/clang -fopenmp test.cpp test.cpp:2:40

Re: r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

2019-05-06 Thread Roman Lebedev via cfe-commits
Thank you! On Mon, May 6, 2019 at 11:05 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 13:07:20 2019 > New Revision: 360073 > > URL: http://llvm.org/viewvc/llvm-project?rev=360073&view=rev > Log: > [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with > d

r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

2019-05-06 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon May 6 13:07:20 2019 New Revision: 360073 URL: http://llvm.org/viewvc/llvm-project?rev=360073&view=rev Log: [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none). If the combined directive has default(none) clause and has clauses for inner directi