Thanks! I committed the fix in r357740. The test should start passing now.
Cheers,
Alex
On Thu, 4 Apr 2019 at 18:32, Stephen Hines wrote:
> Ah I just saw this. Please feel free to CC me on the fix CL and I will
> approve it. I didn't realize that the exact specification was missing
> for that.
Ah I just saw this. Please feel free to CC me on the fix CL and I will
approve it. I didn't realize that the exact specification was missing
for that.
Thanks,
Steve
On Thu, Apr 4, 2019 at 6:31 PM Alex L wrote:
>
> Thanks, for the explanation, it makes sense. It looks like an explicit
> `darwin1
Thanks, for the explanation, it makes sense. It looks like an explicit
`darwin14` in one of the non-versioned darwin triples fixes the issue. I
will commit the fix right away.
Cheers,
Alex
On Thu, 4 Apr 2019 at 18:24, Adrian Prantl wrote:
> IIRC, the dwarf version on Darwin depends on the depl
IIRC, the dwarf version on Darwin depends on the deployment target and is 2 for
earlier versions of macOS and and 4 for newer ones (I need to dig through the
driver code to determine the exact version).
I can take a look at this tomorrow morning.
-- adrian
> On Apr 4, 2019, at 6:21 PM, Alex L
Hi Stephen,
It looks like your change has caused the 'debug-options.c' test to start
failing on Darwin. It looks like we emit "-dwarf-version=4" by default, and
not 2. Could you please take a look.
Here's a link to a latest build on the public LLVM CI that contains the
failure:
http://lab.llvm.or
Author: srhines
Date: Thu Apr 4 11:17:46 2019
New Revision: 357713
URL: http://llvm.org/viewvc/llvm-project?rev=357713&view=rev
Log:
Verify that Android targets generate DWARF 4 by default.
Summary:
In the future, Android releases will support DWARF 5, but we need to
ensure that older targets on
