Re: r356848 - [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

2019-03-24 Thread Craig Topper via cfe-commits
Made a function in r356852 ~Craig On Sun, Mar 24, 2019 at 9:59 AM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This breaks Chromium's build. We have a class with a _bswap method, and > this adds a _bswap macro expanding to something that gets in the way. Could > _bswap be a

Re: r356848 - [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

2019-03-24 Thread Nico Weber via cfe-commits
This breaks Chromium's build. We have a class with a _bswap method, and this adds a _bswap macro expanding to something that gets in the way. Could _bswap be an inline function instead? https://bugs.chromium.org/p/chromium/issues/detail?id=945172 On Sat, Mar 23, 2019 at 8:55 PM Craig Topper via c

r356848 - [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc.

2019-03-23 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Mar 23 17:56:52 2019 New Revision: 356848 URL: http://llvm.org/viewvc/llvm-project?rev=356848&view=rev Log: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h to match gcc. Summary: These are all implemented by icc as well. I made bit_scan_forward/reverse forward to the