Re: r354795 - Make static counters in ASTContext non-static.

2019-02-25 Thread Alexander Kornienko via cfe-commits
Done. r354827 should be better. On Mon, Feb 25, 2019 at 11:18 PM Alexander Kornienko wrote: > Thank you for taking care of this! That's a bug indeed. Will recommit with > a fix. > > On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich > wrote: > >> I've reverted this commit in r354812, it was causi

Re: r354795 - Make static counters in ASTContext non-static.

2019-02-25 Thread Alexander Kornienko via cfe-commits
Thank you for taking care of this! That's a bug indeed. Will recommit with a fix. On Mon, Feb 25, 2019 at 9:25 PM Vlad Tsyrklevich wrote: > I've reverted this commit in r354812, it was causing MSan failures like > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29886/steps/c

Re: r354795 - Make static counters in ASTContext non-static.

2019-02-25 Thread Vlad Tsyrklevich via cfe-commits
I've reverted this commit in r354812, it was causing MSan failures like http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/29886/steps/check-clang%20msan/logs/stdio Though these error reports don't clearly implicate this change, from your change it seems like the failure is occurr

r354795 - Make static counters in ASTContext non-static.

2019-02-25 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Feb 25 08:08:46 2019 New Revision: 354795 URL: http://llvm.org/viewvc/llvm-project?rev=354795&view=rev Log: Make static counters in ASTContext non-static. Summary: Fixes a data race and makes it possible to run clang-based tools in multithreaded environment with TSan. Re