Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-03-19 Thread Aaron Ballman via cfe-commits
On Mon, Mar 18, 2019 at 7:08 PM Dan Gohman wrote: > > > > On Fri, Mar 15, 2019 at 10:55 AM Aaron Ballman wrote: >> >> >> Ping. > > > I apologize for the extraordinarily delays here. I've now posted a patch to > address the review comments here: > > https://reviews.llvm.org/D59520 Delays happen

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-03-18 Thread Dan Gohman via cfe-commits
On Fri, Mar 15, 2019 at 10:55 AM Aaron Ballman wrote: > > Ping. > I apologize for the extraordinarily delays here. I've now posted a patch to address the review comments here: https://reviews.llvm.org/D59520 Dan ___ cfe-commits mailing list cfe-commi

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-03-15 Thread Aaron Ballman via cfe-commits
On Fri, Mar 8, 2019 at 5:06 PM Aaron Ballman wrote: > > On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman wrote: > > > > > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman > > wrote: > >> > >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > >> > > >> > > >> > Indeed, and the existing import_mo

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-03-08 Thread Aaron Ballman via cfe-commits
On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman wrote: > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: >> > >> > >> > Indeed, and the existing import_module attribute needs these tests as >> > well. I'll write some and add them in

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-02-05 Thread Dan Gohman via cfe-commits
On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > > > Indeed, and the existing import_module attribute needs these tests as > well. I'll write some and add them in a follow-up patch. > > > > Thanks for the review! > > Any time! I hav

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-02-05 Thread Aaron Ballman via cfe-commits
On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > > > > On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: >> >> On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits >> wrote: >> > >> > Author: djg >> > Date: Fri Feb 1 14:25:23 2019 >> > New Revision: 352930 >> > >> > URL: http://llvm.or

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-02-01 Thread Dan Gohman via cfe-commits
On Fri, Feb 1, 2019 at 2:31 PM Aaron Ballman wrote: > On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits > wrote: > > > > Author: djg > > Date: Fri Feb 1 14:25:23 2019 > > New Revision: 352930 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > > Log: > > [WebAssembly]

Re: r352930 - [WebAssembly] Add an import_field function attribute

2019-02-01 Thread Aaron Ballman via cfe-commits
On Fri, Feb 1, 2019 at 5:25 PM Dan Gohman via cfe-commits wrote: > > Author: djg > Date: Fri Feb 1 14:25:23 2019 > New Revision: 352930 > > URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev > Log: > [WebAssembly] Add an import_field function attribute > > This is similar to import_modu

r352930 - [WebAssembly] Add an import_field function attribute

2019-02-01 Thread Dan Gohman via cfe-commits
Author: djg Date: Fri Feb 1 14:25:23 2019 New Revision: 352930 URL: http://llvm.org/viewvc/llvm-project?rev=352930&view=rev Log: [WebAssembly] Add an import_field function attribute This is similar to import_module, but sets the import field name instead. By default, the import field name is th