Re: r350340 - Validate -add-plugin arguments.

2019-01-06 Thread Nico Weber via cfe-commits
(Looks like the bot eventually cycled green: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/41779 ) On Fri, Jan 4, 2019 at 8:14 PM Nico Weber wrote: > Thanks for the note. 350451 will hopefully help. > > On Fri, Jan 4, 2019 at 2:18 PM Galina Kistanova via cfe

Re: r350340 - Validate -add-plugin arguments.

2019-01-04 Thread Nico Weber via cfe-commits
Thanks for the note. 350451 will hopefully help. On Fri, Jan 4, 2019 at 2:18 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Nico, > > This commit broke tests on llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast > builder: > > http://lab.llvm.org:8011/builders/llvm-clang

Re: r350340 - Validate -add-plugin arguments.

2019-01-04 Thread Galina Kistanova via cfe-commits
Hello Nico, This commit broke tests on llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/41673 . . . Failing Tests (2): Clang :: CodeGenCXX/debug-info-class-limited-plugin.test Clang :: Frontend/plugin-v

r350340 - Validate -add-plugin arguments.

2019-01-03 Thread Nico Weber via cfe-commits
Author: nico Date: Thu Jan 3 10:26:06 2019 New Revision: 350340 URL: http://llvm.org/viewvc/llvm-project?rev=350340&view=rev Log: Validate -add-plugin arguments. -plugin already prints an error if the name of an unknown plugin is passed. -add-plugin used to silently ignore that, now it errors to