Re: r349063 - [CodeComplete] Adhere to LLVM naming style in CodeCompletionTest. NFC

2018-12-18 Thread Yvan Roux via cfe-commits
On Mon, 17 Dec 2018 at 18:34, Ilya Biryukov wrote: > > Hi Yvan, sorry for the inconvenience. > > I believe this is the same as https://llvm.org/PR40033, should be fixed by > r349362 (the build hasn't finished yet). > I'll double check it's fixed tomorrow and make sure to take another look if > n

Re: r349063 - [CodeComplete] Adhere to LLVM naming style in CodeCompletionTest. NFC

2018-12-17 Thread Ilya Biryukov via cfe-commits
Hi Yvan, sorry for the inconvenience. I believe this is the same as https://llvm.org/PR40033, should be fixed by r349362 (the build hasn't finished yet). I'll double check it's fixed tomorrow and make sure to take another look if not. On Mon, Dec 17, 2018 at 10:46 AM Yvan Roux wrote: > Hi Ilya,

Re: r349063 - [CodeComplete] Adhere to LLVM naming style in CodeCompletionTest. NFC

2018-12-17 Thread Yvan Roux via cfe-commits
Hi Ilya, I'm not sure which one of the commits in that series is to blame, but ARM bots are broken due to a failure in CodeCompleteTest.cpp, most recent logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/6090/steps/ninja%20check%201/logs/FAIL%3A%20Clang-Unit

r349063 - [CodeComplete] Adhere to LLVM naming style in CodeCompletionTest. NFC

2018-12-13 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Thu Dec 13 09:32:38 2018 New Revision: 349063 URL: http://llvm.org/viewvc/llvm-project?rev=349063&view=rev Log: [CodeComplete] Adhere to LLVM naming style in CodeCompletionTest. NFC Also reuses the same var for multiple to reduce the chance of accidentally referecing the p