Re: r348471 - Add test for ObjC generics

2018-12-07 Thread Aaron Ballman via cfe-commits
On Thu, Dec 6, 2018 at 6:29 PM Stephen Kelly wrote: > > > On 06/12/2018 12:48, Aaron Ballman wrote: > > On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits > > wrote: > >> Author: steveire > >> Date: Thu Dec 6 01:23:59 2018 > >> New Revision: 348471 > >> > >> URL: http://llvm.org/viewvc

Re: r348471 - Add test for ObjC generics

2018-12-06 Thread Stephen Kelly via cfe-commits
On 06/12/2018 12:48, Aaron Ballman wrote: On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits wrote: Author: steveire Date: Thu Dec 6 01:23:59 2018 New Revision: 348471 URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev Log: Add test for ObjC generics Modified: cfe/t

Re: r348471 - Add test for ObjC generics

2018-12-06 Thread Aaron Ballman via cfe-commits
On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:23:59 2018 > New Revision: 348471 > > URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev > Log: > Add test for ObjC generics > > Modified: > cfe/trunk/test/AST/ast-dump-decl

Re: r348471 - Add test for ObjC generics

2018-12-06 Thread Roman Lebedev via cfe-commits
Can you please write better commit messages, especially the first subject line? E.g. this should have been "[AST][NFC] Add dump test for ObjC generics" On Thu, Dec 6, 2018 at 12:26 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:23:59 2018 > New Revision: 348471

r348471 - Add test for ObjC generics

2018-12-06 Thread Stephen Kelly via cfe-commits
Author: steveire Date: Thu Dec 6 01:23:59 2018 New Revision: 348471 URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev Log: Add test for ObjC generics Modified: cfe/trunk/test/AST/ast-dump-decl.m Modified: cfe/trunk/test/AST/ast-dump-decl.m URL: http://llvm.org/viewvc/llvm-projec