Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Hi! I had to revert the fix (r348203) in r348280 as this broke our integrate. Also reverted the original change to avoid having compiler-rt in a broken state. Sorry for the inconvenience, see the r348203 thread for more details. On Tue, Dec 4, 2018 at 12:14 AM Adrian Prantl via cfe-commits < cfe-

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Should be fixed in r348211. -- adrian > On Dec 3, 2018, at 3:07 PM, Adrian Prantl via cfe-commits > wrote: > > No, your failures are Windows-specific (/ vs \), and I haven't fixed them > yet. Thanks for letting me know! > > -- adrian > >> On Dec 3, 2018, at 3:06 PM, Galina Kistanova wrote:

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

No, your failures are Windows-specific (/ vs \), and I haven't fixed them yet. Thanks for letting me know! -- adrian > On Dec 3, 2018, at 3:06 PM, Galina Kistanova wrote: > > Adrian, did not see your response, please ignore my email. > > Thanks > > Galina > > On Mon, Dec 3, 2018 at 3:04 PM

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Adrian, did not see your response, please ignore my email. Thanks Galina On Mon, Dec 3, 2018 at 3:04 PM Galina Kistanova wrote: > Hello Adrian, > > This commit broke tests on couple of our builders: > > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14371 > >

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Hello Adrian, This commit broke tests on couple of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14371 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast . . . Failing Tests (2): Clang :: CodeGen/debug-prefix-map

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This should be fixed by LLVM r348203. Thanks for your patience! -- adrian > On Dec 3, 2018, at 1:27 PM, Adrian Prantl via cfe-commits > wrote: > > I'll take a look right away. Thanks for letting me know! > > -- adrian > >> On Dec 3, 2018, at 1:26 PM, Vlad Tsyrklevich wrote: >> >> This chan

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

I'll take a look right away. Thanks for letting me know! -- adrian > On Dec 3, 2018, at 1:26 PM, Vlad Tsyrklevich wrote: > > This change appears to have broken a number of compiler-rt coverage tests, > e.g. in this run >

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This change appears to have broken a number of compiler-rt coverage tests, e.g. in this run . The source of the error appears to be that llvm-cov is now trying to use a relative p

r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Author: adrian Date: Mon Dec 3 09:55:27 2018 New Revision: 348154 URL: http://llvm.org/viewvc/llvm-project?rev=348154&view=rev Log: Avoid emitting redundant or unusable directories in DIFile metadata entries. As discussed on llvm-dev recently, Clang currently emits redundant directories in DIFil