Sorry I lost track of this.
Having understood the code a bit more, the current split between the
AST/analysis/static analyzer isn't as clear as I thought.
So I'm not sure the layering is perfect here, but the fault doesn't lie
with your patch. Sorry for the noise.
On Fri, Nov 2, 2018 at 5:43 PM Ti
On 2 Nov 2018, at 15:28, Sam McCall wrote:
> In that case, I don't think it makes sense to think of the format string
> parser as part of the analyzer - as the build deps suggest, it's now part of
> AST and gets reused by analyzer. (Similar to how the analyzer uses other bits
> of AST/clang). I
On Fri, Nov 2, 2018 at 4:08 PM Tim Northover wrote:
> After that it was discovered OSLog depends on the other format helpers so
> there was still a circular dependency; I decided adding the others was a
> minor enough change to just go ahead.
>
Thanks - I missed the review.
> On 2 Nov 2018, at 1
> On 2 Nov 2018, at 15:03, Tim Northover wrote:
>> (If the do belong here: the namespaces and comments don't seem to have been
>> updated)
>
> Good point, I’ll get onto fixing that.
Actually, do you have any particular ones in mind? After going in to make
changes, they still look pretty good
Hi Sam,
On 2 Nov 2018, at 13:31, Sam McCall wrote:
> The move of OSLog.h and FormatString.h to AST doesn't look obviously correct.
> Do these really belong in this layer? I think this patch needs review from
> someone who knows AST/ better than myself... was there a review?
Eli reviewed the cha
Author: tnorthover
Date: Fri Nov 2 06:14:11 2018
New Revision: 345971
URL: http://llvm.org/viewvc/llvm-project?rev=345971&view=rev
Log:
Reapply Logging: make os_log buffer size an integer constant expression.
The size of an os_log buffer is known at any stage of compilation, so making it
a const
