Re: r345833 - Logging: add CMake dependency so libAST can use OSLog analysis.

2018-11-01 Thread Tim Northover via cfe-commits
Oh bother, I vaguely remember that means I’ll have broken .so builds now? Either way, I’ve reverted the sequence in r345846. I’ll work on putting the os_log machinery into AST and update the review. Thanks for looking out! Tim. > On 1 Nov 2018, at 16:05, Benjamin Kramer wrote: > > This doesn

Re: r345833 - Logging: add CMake dependency so libAST can use OSLog analysis.

2018-11-01 Thread Benjamin Kramer via cfe-commits
This doesn't work. AST cannot depend on Analysis because Analysis already depends on AST. On Thu, Nov 1, 2018 at 3:24 PM Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tnorthover > Date: Thu Nov 1 07:22:20 2018 > New Revision: 345833 > > URL: http://llvm.org/viewvc/

r345833 - Logging: add CMake dependency so libAST can use OSLog analysis.

2018-11-01 Thread Tim Northover via cfe-commits
Author: tnorthover Date: Thu Nov 1 07:22:20 2018 New Revision: 345833 URL: http://llvm.org/viewvc/llvm-project?rev=345833&view=rev Log: Logging: add CMake dependency so libAST can use OSLog analysis. Should fix bots on platforms with slightly different symbol resolution semantics. Modified: