Re: r344241 - [tests] Include Python binding tests in CMake rules

2019-01-16 Thread Nico Weber via cfe-commits
(Follow-up: Michał landed a fix in r351304. Thanks!) On Tue, Jan 15, 2019 at 1:21 PM Nico Weber wrote: > As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note > it's .dylib on macOS and .dll on Windows, and by default > setting LLVM_ENABLE_PIC=OFF causes a static library to be

Re: r344241 - [tests] Include Python binding tests in CMake rules

2019-01-15 Thread Nico Weber via cfe-commits
As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note it's .dylib on macOS and .dll on Windows, and by default setting LLVM_ENABLE_PIC=OFF causes a static library to be created instead on non-win). On Tue, Jan 15, 2019 at 1:16 PM Michał Górny wrote: > On Tue, 2019-01-15 at 13:

Re: r344241 - [tests] Include Python binding tests in CMake rules

2019-01-15 Thread Michał Górny via cfe-commits
On Tue, 2019-01-15 at 13:10 -0500, Nico Weber wrote: > The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since > they all fail there (due to lib/libclang.so not existing). Hmm, maybe we could make them conditional to the existence of libclang.so target? Would that work for you? >

Re: r344241 - [tests] Include Python binding tests in CMake rules

2019-01-15 Thread Nico Weber via cfe-commits
The tests probably shouldn't run when LLVM_ENABLE_PIC=OFF is set, since they all fail there (due to lib/libclang.so not existing). On Thu, Oct 11, 2018 at 7:59 AM Michal Gorny via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mgorny > Date: Thu Oct 11 04:58:14 2018 > New Revision: 34

r344241 - [tests] Include Python binding tests in CMake rules

2018-10-11 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Thu Oct 11 04:58:14 2018 New Revision: 344241 URL: http://llvm.org/viewvc/llvm-project?rev=344241&view=rev Log: [tests] Include Python binding tests in CMake rules Add a new CMake rule check-clang-python to run the Python bindings' test suite, and include it in check-all. Di