Re: r343790 - [clang] Add the exclude_from_explicit_instantiation attribute

2018-10-05 Thread Louis Dionne via cfe-commits
I just saw this. Simon Pilgrim already fixed it in r343846. Thanks Simon! Louis > On Oct 4, 2018, at 22:02, Galina Kistanova wrote: > > Hello Louis, > > This commit broke build step on one of our builders: > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/13042

Re: r343790 - [clang] Add the exclude_from_explicit_instantiation attribute

2018-10-04 Thread Galina Kistanova via cfe-commits
Hello Louis, This commit broke build step on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/13042 . . . FAILED: tools/clang/lib/Sema/CMakeFiles/clangSema.dir/SemaExprCXX.cpp.obj C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP -DEXPENSI

r343790 - [clang] Add the exclude_from_explicit_instantiation attribute

2018-10-04 Thread Louis Dionne via cfe-commits
Author: ldionne Date: Thu Oct 4 08:49:42 2018 New Revision: 343790 URL: http://llvm.org/viewvc/llvm-project?rev=343790&view=rev Log: [clang] Add the exclude_from_explicit_instantiation attribute Summary: This attribute allows excluding a member of a class template from being part of an explicit