Sorry for the unresponsiveness, I've been fire fighting for other stuffs.
I'll look into this and try to get it fixed this week.
On Tue, Nov 6, 2018 at 9:52 AM David Blaikie wrote:
> Shuai - have you had a chance to look at this?
>
> On Mon, Oct 22, 2018 at 4:43 PM Richard Smith
> wrote:
>
>> O
Shuai - have you had a chance to look at this?
On Mon, Oct 22, 2018 at 4:43 PM Richard Smith wrote:
> On Mon, 22 Oct 2018 at 14:57, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Richard - any further thoughts here (re: layering/dependencies, etc)?
>> Would love to get
On Mon, 22 Oct 2018 at 14:57, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Richard - any further thoughts here (re: layering/dependencies, etc)?
> Would love to get the layering oddity fixed rather than having it get more
> embedded over time.
>
Here's the intended current
Richard - any further thoughts here (re: layering/dependencies, etc)? Would
love to get the layering oddity fixed rather than having it get more
embedded over time.
On Tue, Oct 2, 2018 at 2:44 PM Shuai Wang via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 1, 2018 at 4:58 PM Rich
On Mon, Oct 1, 2018 at 4:58 PM Richard Smith wrote:
> On Mon, 1 Oct 2018 at 16:10, George Karpenkov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi Richard,
>>
>> On Oct 1, 2018, at 2:50 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>> This looks like
I was building with -DLLVM_ENABLE_MODULES=ON -DBUILD_SHARED_LIBS=ON. I
think that's enough to trigger it?
/Eric
On Mon, Oct 1, 2018 at 4:13 PM David Blaikie wrote:
> I can't really reproduce this - when I try to build clang/llvm with
> LLVM_ENABLE_MODULES in CMake I'm still seeing an error I re
On Mon, 1 Oct 2018 at 16:10, George Karpenkov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> On Oct 1, 2018, at 2:50 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> This looks like the wrong fix to me, but I don't really know enough about
> what
Hi Richard,
> On Oct 1, 2018, at 2:50 PM, Richard Smith via cfe-commits
> wrote:
>
> This looks like the wrong fix to me, but I don't really know enough about
> what's being done with ExprMutationAnalyzer to have an opinion on what the
> right fix is.
>
> Shuai, what is the goal here? Why is
George wanted to use it from clang (or, at least can't use from anything
from clang-tidy.) I was actually assuming the intended usage is from some
tooling instead of the frontend itself, but I never checked with George.
Personally I don't think ExprMutationAnalyzer should be used in anywhere
other
This looks like the wrong fix to me, but I don't really know enough about
what's being done with ExprMutationAnalyzer to have an opinion on what the
right fix is.
Shuai, what is the goal here? Why is this code being moved to Analysis/? Do
you intend to call it from the compiler frontend at some po
I can't really reproduce this - when I try to build clang/llvm with
LLVM_ENABLE_MODULES in CMake I'm still seeing an error I reported March on
a cfe-dev thread - something to do with unique_ptr instantiations for
MappedBlockStream in the PDB parsing code.
So, I'm wondering what error you hit, Eric
+rsmith (actually this time)
On Sun, Sep 30, 2018 at 12:09 PM Eric Fiselier wrote:
> +rsmith
>
> Hi All,
>
> Sorry, I'm not actually sure why this fix is correct.I stole both the fix
> and the comment from a similar one on L150 of the module map left by
> Richard Smith.
>
> /Eric
>
> On Tue, Sep
+rsmith
Hi All,
Sorry, I'm not actually sure why this fix is correct.I stole both the fix
and the comment from a similar one on L150 of the module map left by
Richard Smith.
/Eric
On Tue, Sep 25, 2018 at 8:36 PM Shuai Wang wrote:
> I'd like to understand this better as well, in particular wha
I'd like to understand this better as well, in particular what would be a
proper fix?
On Tue, Sep 25, 2018 at 2:15 PM David Blaikie wrote:
> +Shuai Wang
>
> On Tue, Sep 25, 2018 at 2:14 PM David Blaikie wrote:
>
>> Hey Eric - thanks for the fix - but could you explain the issue here in a
>> bit
+Shuai Wang
On Tue, Sep 25, 2018 at 2:14 PM David Blaikie wrote:
> Hey Eric - thanks for the fix - but could you explain the issue here in a
> bit more detail, as I'm a bit confused (& really interested in
> understanding any layering problems in LLVM - and fixing them/making sure
> they're fixe
Hey Eric - thanks for the fix - but could you explain the issue here in a
bit more detail, as I'm a bit confused (& really interested in
understanding any layering problems in LLVM - and fixing them/making sure
they're fixed/holding the line/etc)
What do you mean by "pull all of the AST matchers l
Author: ericwf
Date: Sat Sep 22 17:48:05 2018
New Revision: 342827
URL: http://llvm.org/viewvc/llvm-project?rev=342827&view=rev
Log:
Fix modules build with shared library.
r341994 caused clangAnalysis to pull all of the AST matchers
library into clang. Due to inline key functions in the headers,
17 matches
Mail list logo
