Re: r342793 - [Lexer] Add udefined_behavior_sanitizer feature

2018-09-21 Thread Leonard Chan via cfe-commits
My bad. I saw that Vitaly accepted it and thought it would be ok since I got 2 LGTMs. On Fri, Sep 21, 2018 at 6:21 PM Aaron Ballman wrote: > > The reviewer asked you to wait a day so that others might have a > chance to review it, so this commit seems premature. I have no > technical concerns with

Re: r342793 - [Lexer] Add udefined_behavior_sanitizer feature

2018-09-21 Thread Aaron Ballman via cfe-commits
The reviewer asked you to wait a day so that others might have a chance to review it, so this commit seems premature. I have no technical concerns with the patch, but the sanitizer owners should have had a chance to weigh in. That said, I don't see value in reverting and recommitting later, so if t

r342793 - [Lexer] Add udefined_behavior_sanitizer feature

2018-09-21 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Fri Sep 21 18:03:16 2018 New Revision: 342793 URL: http://llvm.org/viewvc/llvm-project?rev=342793&view=rev Log: [Lexer] Add udefined_behavior_sanitizer feature This can be used to detect whether the code is being built with UBSan using the __has_feature(undefined_behavio