Re: r342221 - [analyzer][UninitializedObjectChecker] Support for nonloc::LocAsInteger

2018-09-14 Thread Ilya Biryukov via cfe-commits
I've sent a quick workaround restoring final (r342225) to unbreak our internal buildbots. On Fri, Sep 14, 2018 at 1:20 PM Ilya Biryukov wrote: > Ah, the reason why it does not fire on other inheritors is because they're > final. Any reason to remove final from NeedsCastLocField? > > On Fri, Sep

Re: r342221 - [analyzer][UninitializedObjectChecker] Support for nonloc::LocAsInteger

2018-09-14 Thread Ilya Biryukov via cfe-commits
Ah, the reason why it does not fire on other inheritors is because they're final. Any reason to remove final from NeedsCastLocField? On Fri, Sep 14, 2018 at 1:17 PM Ilya Biryukov wrote: > This introduced revision introduced a new warning: > ../tools/clang/lib/StaticAnalyzer/Checkers/Uninitialize

Re: r342221 - [analyzer][UninitializedObjectChecker] Support for nonloc::LocAsInteger

2018-09-14 Thread Ilya Biryukov via cfe-commits
This introduced revision introduced a new warning: ../tools/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:62:7: warning: '(anonymous namespace)::NeedsCastLocField' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor] Which is turned into an error o

r342221 - [analyzer][UninitializedObjectChecker] Support for nonloc::LocAsInteger

2018-09-14 Thread Kristof Umann via cfe-commits
Author: szelethus Date: Fri Sep 14 03:18:26 2018 New Revision: 342221 URL: http://llvm.org/viewvc/llvm-project?rev=342221&view=rev Log: [analyzer][UninitializedObjectChecker] Support for nonloc::LocAsInteger Differential Revision: https://reviews.llvm.org/D49437 Modified: cfe/trunk/lib/Stat