Re: r341539 - [OpenCL] Disallow negative attribute arguments

2018-09-06 Thread Aaron Ballman via cfe-commits
On Thu, Sep 6, 2018 at 10:00 AM, Andrew Savonichev wrote: > Hi Aaron, > >> On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits >> wrote: >>> Author: asavonic >>> Date: Thu Sep 6 04:54:09 2018 >>> New Revision: 341539 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=

Re: r341539 - [OpenCL] Disallow negative attribute arguments

2018-09-06 Thread Andrew Savonichev via cfe-commits
Hi Aaron, > On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits > wrote: >> Author: asavonic >> Date: Thu Sep 6 04:54:09 2018 >> New Revision: 341539 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev >> Log: >> [OpenCL] Disallow negative attribute arguments >> >> [

Re: r341539 - [OpenCL] Disallow negative attribute arguments

2018-09-06 Thread Aaron Ballman via cfe-commits
On Thu, Sep 6, 2018 at 7:54 AM, Andrew Savonichev via cfe-commits wrote: > Author: asavonic > Date: Thu Sep 6 04:54:09 2018 > New Revision: 341539 > > URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev > Log: > [OpenCL] Disallow negative attribute arguments > > Summary: > Negative argum

r341539 - [OpenCL] Disallow negative attribute arguments

2018-09-06 Thread Andrew Savonichev via cfe-commits
Author: asavonic Date: Thu Sep 6 04:54:09 2018 New Revision: 341539 URL: http://llvm.org/viewvc/llvm-project?rev=341539&view=rev Log: [OpenCL] Disallow negative attribute arguments Summary: Negative arguments in kernel attributes are silently bitcast'ed to unsigned, for example: __attribute