Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-11-26 Thread Richard Smith via cfe-commits
> > *Subject: *Re: r338941 - [constexpr] Support for constant evaluation of > __builtin_memcpy and > > > > On Mon, 26 Nov 2018, 11:50 Richard Smith > On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits < > cfe-commits@lists.llvm.org wrote: > > If it's

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-11-26 Thread Shoaib Meenai via cfe-commits
: Shoaib Meenai Cc: cfe-commits , Tom Stellard Subject: Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and On Mon, 26 Nov 2018, 11:50 Richard Smith mailto:rich...@metafoo.co.uk> wrote: On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits mailto:cfe-comm

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-11-26 Thread Richard Smith via cfe-commits
On Mon, 26 Nov 2018, 11:50 Richard Smith On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits < > cfe-commits@lists.llvm.org wrote: > >> If it's not too late, could we have this as part of 7.0.1? (You'll also >> need to cherry-pick the initial reversion in r338602.) >> > > The revert was cherr

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-11-26 Thread Richard Smith via cfe-commits
On Wed, 21 Nov 2018, 15:32 Shoaib Meenai via cfe-commits < cfe-commits@lists.llvm.org wrote: > If it's not too late, could we have this as part of 7.0.1? (You'll also > need to cherry-pick the initial reversion in r338602.) > The revert was cherrypicked onto the branch in r338674. Was that not in

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-11-26 Thread Tom Stellard via cfe-commits
On 11/21/2018 03:32 PM, Shoaib Meenai wrote: > If it's not too late, could we have this as part of 7.0.1? (You'll also need > to cherry-pick the initial reversion in r338602.) 7.0 hits assertion failures > for pretty basic memcpy cases on windows-msvc targets, and this patch fixes > that. > I'

Re: r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-11-21 Thread Shoaib Meenai via cfe-commits
If it's not too late, could we have this as part of 7.0.1? (You'll also need to cherry-pick the initial reversion in r338602.) 7.0 hits assertion failures for pretty basic memcpy cases on windows-msvc targets, and this patch fixes that. % cat /tmp/reduced.c void *memcpy(void *, const void *, __SIZ

r338941 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 3 17:57:17 2018 New Revision: 338941 URL: http://llvm.org/viewvc/llvm-project?rev=338941&view=rev Log: [constexpr] Support for constant evaluation of __builtin_memcpy and __builtin_memmove (in non-type-punning cases). This is intended to permit libc++ to make std::co