Re: r338139 - [OPENMP] Static variables on device must be externally visible.

2018-07-27 Thread Jonas Hahnfeld via cfe-commits
Hi Alexey, from what I can see this change can't handle the case where there are static variables with the same name in multiple TUs. (The same problem exists for static CUDA kernels with -fcuda-rdc. I found that nvcc mangles the function names in this case, but didn't have time yet to prepare

r338139 - [OPENMP] Static variables on device must be externally visible.

2018-07-27 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Jul 27 10:37:32 2018 New Revision: 338139 URL: http://llvm.org/viewvc/llvm-project?rev=338139&view=rev Log: [OPENMP] Static variables on device must be externally visible. Do not mark static variable as internal on the device as they must be visible from the host to be m