Re: r337627 - Fold dangling-field warning into general initialization lifetime checks.

2018-07-23 Thread Richard Smith via cfe-commits
Thanks, fixed and re-committed in r337726. On Sun, 22 Jul 2018 at 23:33, Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Reverted in r337671 > > On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov > wrote: > >> Hi Richard, >> >> this commit seems to cause invalid warning in the fo

Re: r337627 - Fold dangling-field warning into general initialization lifetime checks.

2018-07-22 Thread Ilya Biryukov via cfe-commits
Reverted in r337671 On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov wrote: > Hi Richard, > > this commit seems to cause invalid warning in the following example: > > struct foo { > foo(char *x) : x_(&x[10]) {} // > private: > char *x_; > }; > > The warning itself: > 1.cpp:2:21: warning: initia

Re: r337627 - Fold dangling-field warning into general initialization lifetime checks.

2018-07-22 Thread Ilya Biryukov via cfe-commits
Hi Richard, this commit seems to cause invalid warning in the following example: struct foo { foo(char *x) : x_(&x[10]) {} // private: char *x_; }; The warning itself: 1.cpp:2:21: warning: initializing pointer member 'x_' with the stack address of parameter 'x' [-Wdangling-field] I'll rever

r337627 - Fold dangling-field warning into general initialization lifetime checks.

2018-07-20 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jul 20 15:25:55 2018 New Revision: 337627 URL: http://llvm.org/viewvc/llvm-project?rev=337627&view=rev Log: Fold dangling-field warning into general initialization lifetime checks. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/S