Re: r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-23 Thread Richard Smith via cfe-commits
OK, thanks for the revert. On Wed, 23 May 2018, 01:28 Hans Wennborg via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > We're hitting asserts after this in Chromium. I've filed PR37560 and > reverted in r333067. > > On Wed, May 23, 2018 at 2:09 AM, Richard Smith via cfe-commits > wrote: > >

Re: r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-23 Thread Hans Wennborg via cfe-commits
We're hitting asserts after this in Chromium. I've filed PR37560 and reverted in r333067. On Wed, May 23, 2018 at 2:09 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue May 22 17:09:29 2018 > New Revision: 333044 > > URL: http://llvm.org/viewvc/llvm-project?rev=333044&view=rev

r333067 - Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array initializers"

2018-05-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed May 23 01:24:01 2018 New Revision: 333067 URL: http://llvm.org/viewvc/llvm-project?rev=333067&view=rev Log: Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array initializers" It caused asserts, see PR37560. > Use zeroinitiali

r333044 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 22 17:09:29 2018 New Revision: 333044 URL: http://llvm.org/viewvc/llvm-project?rev=333044&view=rev Log: Use zeroinitializer for (trailing zero portion of) large array initializers more reliably. Clang has two different ways it emits array constants (from InitListExprs