Re: r332436 - clang-format: Allow optimizer to break template declaration.

2018-05-16 Thread Eric Liu via cfe-commits
This should be fixed by r332465 On Wed, May 16, 2018 at 2:50 PM Eric Liu wrote: > OK, I'll send a fix for the index test. Please make sure you run all clang > tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a > patch! Thanks! > > On Wed, May 16, 2018 at 2:32 PM Eric Liu

Re: r332436 - clang-format: Allow optimizer to break template declaration.

2018-05-16 Thread Eric Liu via cfe-commits
OK, I'll send a fix for the index test. Please make sure you run all clang tests (`ninja check-clang` and `ninja check-clang-tools`) before landing a patch! Thanks! On Wed, May 16, 2018 at 2:32 PM Eric Liu wrote: > I can also reproduce on my local machine (Debian). > > On Wed, May 16, 2018 at 1:

Re: r332436 - clang-format: Allow optimizer to break template declaration.

2018-05-16 Thread Eric Liu via cfe-commits
I can also reproduce on my local machine (Debian). On Wed, May 16, 2018 at 1:01 PM David Zarzycki via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red > Hat Fedora 28. Was this expected? > > > On May 16, 2018, at 4:25 AM, F

Re: r332436 - clang-format: Allow optimizer to break template declaration.

2018-05-16 Thread David Zarzycki via cfe-commits
This change broke `test/Index/overriding-ftemplate-comments.cpp` on Red Hat Fedora 28. Was this expected? > On May 16, 2018, at 4:25 AM, Francois Ferrand via cfe-commits > wrote: > > Author: typz > Date: Wed May 16 01:25:03 2018 > New Revision: 332436 > > URL: http://llvm.org/viewvc/llvm-proj

r332436 - clang-format: Allow optimizer to break template declaration.

2018-05-16 Thread Francois Ferrand via cfe-commits
Author: typz Date: Wed May 16 01:25:03 2018 New Revision: 332436 URL: http://llvm.org/viewvc/llvm-project?rev=332436&view=rev Log: clang-format: Allow optimizer to break template declaration. Summary: Introduce `PenaltyBreakTemplateDeclaration` to control the penalty, and change `AlwaysBreakTempl