Re: r329617 - [ObjC++] Never pass structs that transitively contain __weak fields in

2018-04-09 Thread Akira Hatanaka via cfe-commits
Sorry for the breakage, I reverted the patch in r329627 and reapplied it with a fix in r329635. Let me know if the tests are still failing. > On Apr 9, 2018, at 3:47 PM, Galina Kistanova wrote: > > Hello Akira, > > This commit added broken tests to one of our builders: > http://lab.llvm.org:80

Re: r329617 - [ObjC++] Never pass structs that transitively contain __weak fields in

2018-04-09 Thread Galina Kistanova via cfe-commits
Hello Akira, This commit added broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/8964 Failing Tests (8): Clang :: CodeGenObjCXX/objc-struct-cxx-abi.mm Clang :: SemaObjCXX/attr-trivial-abi.mm . . . Please have a look? The

r329617 - [ObjC++] Never pass structs that transitively contain __weak fields in

2018-04-09 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Mon Apr 9 13:39:47 2018 New Revision: 329617 URL: http://llvm.org/viewvc/llvm-project?rev=329617&view=rev Log: [ObjC++] Never pass structs that transitively contain __weak fields in registers. This patch fixes a bug in r328731 that caused structs transitively containing __