Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-06 Thread Manoj Gupta via cfe-commits
Sure, will update. Thanks, Manoj On Fri, Apr 6, 2018 at 4:56 AM Nico Weber wrote: > This should probably get a release notes entry. Can you write one? > > On Thu, Apr 5, 2018 at 11:29 AM, Manoj Gupta via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: manojgupta >> Date: Thu Apr

Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-06 Thread Nico Weber via cfe-commits
This should probably get a release notes entry. Can you write one? On Thu, Apr 5, 2018 at 11:29 AM, Manoj Gupta via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: manojgupta > Date: Thu Apr 5 08:29:52 2018 > New Revision: 329300 > > URL: http://llvm.org/viewvc/llvm-project?rev=329300

Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-05 Thread Manoj Gupta via cfe-commits
Thanks Richard, I was wondering how a Clang change can break the Backend tests given that the tests are all pre-checked IR files. Failing Tests (7): LLVM :: CodeGen/Mips/Fast-ISel/fastalloca.ll LLVM :: CodeGen/Mips/Fast-ISel/fastcc-miss.ll LLVM :: CodeGen/Mips/Fast-ISel/memtest1.ll

Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-05 Thread Richard Smith via cfe-commits
MipsFastISel::fastLowerArguments looks very broken and is likely the culprit here: const ArrayRef GPR32ArgRegs = {Mips::A0, Mips::A1, Mips::A2, Mips::A3}; const ArrayRef FGR32ArgRegs = {Mips::F12, Mips::F14}; const ArrayRef AFGR64ArgRegs = {Mips::D

Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-05 Thread Galina Kistanova via cfe-commits
Hello Manoj, Looks like this commit broke tests at couple of our builders: r329300 http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/9600 Few tests failed: . . . Failing Tests (7): LLVM :: CodeGen/Mips/Fast-ISel/fastalloca.ll LLVM :: CodeGen/Mips/Fast-ISel/fastcc-miss.ll

r329300 - Disable -fmerge-all-constants as default.

2018-04-05 Thread Manoj Gupta via cfe-commits
Author: manojgupta Date: Thu Apr 5 08:29:52 2018 New Revision: 329300 URL: http://llvm.org/viewvc/llvm-project?rev=329300&view=rev Log: Disable -fmerge-all-constants as default. Summary: "-fmerge-all-constants" is a non-conforming optimization and should not be the default. It is also causing mi