Re: r328040 - Set dso_local on string literals.

2018-03-22 Thread Joerg Sonnenberger via cfe-commits
On Tue, Mar 20, 2018 at 05:01:24PM -0700, Rafael Avila de Espindola wrote: > Joerg Sonnenberger via cfe-commits writes: > > > On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits > > wrote: > >> Author: rafael > >> Date: Tue Mar 20 13:42:55 2018 > >> New Revision: 328040 >

Re: r328040 - Set dso_local on string literals.

2018-03-20 Thread Rafael Avila de Espindola via cfe-commits
Joerg Sonnenberger via cfe-commits writes: > On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits > wrote: >> Author: rafael >> Date: Tue Mar 20 13:42:55 2018 >> New Revision: 328040 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev >> Log: >> Set dso_loca

Re: r328040 - Set dso_local on string literals.

2018-03-20 Thread Joerg Sonnenberger via cfe-commits
On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits wrote: > Author: rafael > Date: Tue Mar 20 13:42:55 2018 > New Revision: 328040 > > URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev > Log: > Set dso_local on string literals. I wonder if unnamed_addr shouldn'

r328040 - Set dso_local on string literals.

2018-03-20 Thread Rafael Espindola via cfe-commits
Author: rafael Date: Tue Mar 20 13:42:55 2018 New Revision: 328040 URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev Log: Set dso_local on string literals. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/test/CodeGen/c-strings.c cfe/trunk/test/CodeGen/string-lit