Re: r327738 - [MS] Don't escape MS C++ names with \01

2018-03-19 Thread Rafael Avila de Espindola via cfe-commits
Thanks! Reid Kleckner via cfe-commits writes: > Author: rnk > Date: Fri Mar 16 13:36:49 2018 > New Revision: 327738 > > URL: http://llvm.org/viewvc/llvm-project?rev=327738&view=rev > Log: > [MS] Don't escape MS C++ names with \01 > > It is not needed after LLVM r327734. Now it will be easier to

Re: r327738 - [MS] Don't escape MS C++ names with \01

2018-03-18 Thread Nico Weber via cfe-commits
Awesome, thanks! On Sun, Mar 18, 2018, 3:05 PM Reid Kleckner wrote: > Yes: https://reviews.llvm.org/D7775 > > This side is very mechanical, so I did not send it for review. > > > On Sun, Mar 18, 2018, 3:54 AM Nico Weber wrote: > >> Was this discussed or reviewed somewhere? (It looks like a good

Re: r327738 - [MS] Don't escape MS C++ names with \01

2018-03-18 Thread Reid Kleckner via cfe-commits
Yes: https://reviews.llvm.org/D7775 This side is very mechanical, so I did not send it for review. On Sun, Mar 18, 2018, 3:54 AM Nico Weber wrote: > Was this discussed or reviewed somewhere? (It looks like a good change to > me, I'm just wondering if there was something that triggered this and