Re: r325321 - [Sema] Take into account the current context when checking the

2018-02-16 Thread Akira Hatanaka via cfe-commits
Thanks for taking care of it. It looks like I had to traverse the chain of Scopes upwards until Scope::getEntity() returns something that is not null. This is a reduced test case. clang doesn’t crash if I remove “if (true)”. $ cat test1.cpp struct CmapSubtable {}; struct A { protected: typ

Re: r325321 - [Sema] Take into account the current context when checking the

2018-02-16 Thread Hans Wennborg via cfe-commits
Reverted in r325335 as this broke the Chromium build. See https://bugs.chromium.org/p/chromium/issues/detail?id=813017 for stack trace and reproducer. (I think Ben said it might have also broken a Clang bootstrap build, but I didn't see that anywhere?) On Fri, Feb 16, 2018 at 9:47 AM, Akira Hata

r325335 - Revert r325321 "[Sema] Take into account the current context when checking the"

2018-02-16 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Feb 16 04:06:32 2018 New Revision: 325335 URL: http://llvm.org/viewvc/llvm-project?rev=325335&view=rev Log: Revert r325321 "[Sema] Take into account the current context when checking the" This broke the Chromium build, see https://crbug.com/813017 > a

r325321 - [Sema] Take into account the current context when checking the

2018-02-16 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Fri Feb 16 00:47:37 2018 New Revision: 325321 URL: http://llvm.org/viewvc/llvm-project?rev=325321&view=rev Log: [Sema] Take into account the current context when checking the accessibility of a class member. This fixes PR32898. rdar://problem/33737747 Differential revisio