Re: r321997 - Avoid assumption that lit tests are writable. NFC

2018-01-08 Thread Sam McCall via cfe-commits
Hi David (and the list this time!), If X is readonly, then after `cp X Y`, Y is also readonly. The `cat` version doesn't propagate permissions. The environment for lit tests isn't really spelled out, but relying on the input files being +w doesn't seem obviously reasonable. Google's internal runn

Re: r321997 - Avoid assumption that lit tests are writable. NFC

2018-01-08 Thread David Blaikie via cfe-commits
I'm sure it's something obvious I don't understand here, but maybe someone else doesn't either & could benefit from it: What exactly does this change do? In what important way is "cp X Y" different from "cat X > Y"? On Mon, Jan 8, 2018 at 7:06 AM Sam McCall via cfe-commits < cfe-commits@lists.llv

r321997 - Avoid assumption that lit tests are writable. NFC

2018-01-08 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Jan 8 07:05:01 2018 New Revision: 321997 URL: http://llvm.org/viewvc/llvm-project?rev=321997&view=rev Log: Avoid assumption that lit tests are writable. NFC Modified: cfe/trunk/test/ARCMT/releases-driver.m cfe/trunk/test/ARCMT/releases-driver.m.result cfe/