Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-16 Thread Alexey Bataev via cfe-commits
Hi Hans, I don't think we need to merge some of these to 6.0 branch, they are not bug fixes, just some new functionality - Best regards, Alexey Bataev 16.01.2018 9:59, Hans Wennborg пишет: > Please file a merge request bug blocking PR35804 for what you'd like > merged (unless you alre

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-16 Thread Hans Wennborg via cfe-commits
Please file a merge request bug blocking PR35804 for what you'd like merged (unless you already have). Thanks, Hans On Mon, Jan 8, 2018 at 5:27 PM, Alexey Bataev via cfe-commits wrote: > Will add some more tests later today > - > Best regards, > Alexey Bataev > > 08.01.2018 11:13, Da

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-08 Thread Alexey Bataev via cfe-commits
Will add some more tests later today - Best regards, Alexey Bataev 08.01.2018 11:13, David Blaikie пишет: > Rough guess: That seems like a lot of code changes for relatively > little test changes - are all parts of this change tested? (Might well > be - just lots of layers to plumb thi

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-08 Thread David Blaikie via cfe-commits
Rough guess: That seems like a lot of code changes for relatively little test changes - are all parts of this change tested? (Might well be - just lots of layers to plumb things through - but if there's lots of places that get locations and only a few of those are tested, maybe this could use more

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-05 Thread Alexey Bataev via cfe-commits
Yes, I mean these 2. - Best regards, Alexey Bataev 04.01.2018 16:02, Jonas Hahnfeld пишет: > You mean r321818 and r321820? I skipped them because they are for > NVPTX and target directives which aren't fully functional in 6.0 > anyway, right? > Or patches in the future? > > Am 2018-01

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-05 Thread Alexey Bataev via cfe-commits
Hi Jonas, I don't think it is necessary. It is better to backport my 2 next patches with bug fixes. Best regards, Alexey 04.01.2018 15:54, Jonas Hahnfeld пишет: > Hi Alexey, > > should this change be backported to 6.0? > > Regards, > Jonas > > Am 2018-01-04 20:45, schrieb Alexey Bataev via cfe-co

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-04 Thread Jonas Hahnfeld via cfe-commits
You mean r321818 and r321820? I skipped them because they are for NVPTX and target directives which aren't fully functional in 6.0 anyway, right? Or patches in the future? Am 2018-01-04 21:58, schrieb Alexey Bataev: Hi Jonas, I don't think it is necessary. It is better to backport my 2 next pa

Re: r321816 - [OPENMP] Add debug info for generated functions.

2018-01-04 Thread Jonas Hahnfeld via cfe-commits
Hi Alexey, should this change be backported to 6.0? Regards, Jonas Am 2018-01-04 20:45, schrieb Alexey Bataev via cfe-commits: Author: abataev Date: Thu Jan 4 11:45:16 2018 New Revision: 321816 URL: http://llvm.org/viewvc/llvm-project?rev=321816&view=rev Log: [OPENMP] Add debug info for gene

r321816 - [OPENMP] Add debug info for generated functions.

2018-01-04 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Jan 4 11:45:16 2018 New Revision: 321816 URL: http://llvm.org/viewvc/llvm-project?rev=321816&view=rev Log: [OPENMP] Add debug info for generated functions. Most of the generated functions for the OpenMP were generated with disabled debug info. Patch fixes this for bette