Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Seems to be working now. Thank you! On Thu, Jan 11, 2018 at 9:46 PM, Richard Trieu wrote: > Hi Vedant and Eric, > > Please retry after r322350. I suspect an interaction between templates > and friend functions is causing this issue. This revision disables hashing > for friend functions for no

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Hi Vedant and Eric, Please retry after r322350. I suspect an interaction between templates and friend functions is causing this issue. This revision disables hashing for friend functions for now. Richard On Thu, Jan 11, 2018 at 3:34 PM, Eric Fiselier wrote: > I'm hitting the same issue as we

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

I'm hitting the same issue as well. Please let me know if there is anything I can do to get this fixed quickly. /Eric On Wed, Jan 3, 2018 at 5:20 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Vedant, > > I'm looking into it. > > > On Wed, Jan 3, 2018 at 11:12 AM, Veda

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Vedant, I'm looking into it. On Wed, Jan 3, 2018 at 11:12 AM, Vedant Kumar wrote: > Oops, the build log was too big to attach. Resending with just the bot > link, then: > http://lab.llvm.org:8080/green/view/Experimental/job/ > clang-stage2-coverage-R/2193/consoleText > > vedant > > On Jan 3, 20

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Oops, the build log was too big to attach. Resending with just the bot link, then: http://lab.llvm.org:8080/green/view/Experimental/job/clang-stage2-coverage-R/2193/consoleText vedant > On Jan 3, 20

r321395 - [ODRHash] Support ODR violation detection in functions.

Author: rtrieu Date: Fri Dec 22 16:41:01 2017 New Revision: 321395 URL: http://llvm.org/viewvc/llvm-project?rev=321395&view=rev Log: [ODRHash] Support ODR violation detection in functions. Extend the hashing to functions, which allows detection of function definition mismatches across modules. T