Reverted the original patch too, in r318667 since I assume that was
breaking Ilya's build.
Hopefully this is easy to fix and they can be re-landed together.
On Mon, Nov 20, 2017 at 9:39 AM, Hans Wennborg wrote:
> I've reverted in r318665 to get the buildbots green until this is figured out.
>
>
I've reverted in r318665 to get the buildbots green until this is figured out.
On Sat, Nov 18, 2017 at 11:55 AM, Hans Wennborg wrote:
> We're still seeing some in macro-related code. From Chromium:
>
> ../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if
> statement has empty body
Author: hans
Date: Mon Nov 20 09:38:16 2017
New Revision: 318665
URL: http://llvm.org/viewvc/llvm-project?rev=318665&view=rev
Log:
Revert r318556 "Loosen -Wempty-body warning"
It seems this somehow made -Wempty-body fire in some macro cases where
it didn't before, e.g.
We're still seeing some in macro-related code. From Chromium:
../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if
statement has empty body [-Werror,-Wempty-body]
ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size);
^
../../third_party/ffmpeg\libavutil/inte
Author: rnk
Date: Fri Nov 17 13:33:28 2017
New Revision: 318556
URL: http://llvm.org/viewvc/llvm-project?rev=318556&view=rev
Log:
Loosen -Wempty-body warning
Do not show it when `if` or `else` come from macros.
E.g.,
#define USED(A) if (A); else
#define SOME_IF(A) if (A)
void test()
