That's a good idea! I'll commit an llvm_unreachable fix for this override
then.
On 16 October 2017 at 10:32, David Blaikie wrote:
> Generally it's preferably to avoid adding dead code (partly for this
> reason - it's hard to track when it gets used and ensure it's appropriately
> tested) could t
Generally it's preferably to avoid adding dead code (partly for this reason
- it's hard to track when it gets used and ensure it's appropriately
tested) could the member function's body be replaced with llvm_unreachable
for now, then?
On Mon, Oct 16, 2017 at 10:27 AM Alex L wrote:
> At the momen
At the moment this method override is not used by the clang-refactor tool,
so I don't think I can add a test for it.
On 16 October 2017 at 10:11, David Blaikie wrote:
> Is there a test that could be added to cover this new code?
>
> On Fri, Oct 13, 2017 at 2:15 PM Alex Lorenz via cfe-commits <
>
Is there a test that could be added to cover this new code?
On Fri, Oct 13, 2017 at 2:15 PM Alex Lorenz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: arphaman
> Date: Fri Oct 13 14:15:25 2017
> New Revision: 315755
>
> URL: http://llvm.org/viewvc/llvm-project?rev=315755&view=rev
Author: arphaman
Date: Fri Oct 13 14:15:25 2017
New Revision: 315755
URL: http://llvm.org/viewvc/llvm-project?rev=315755&view=rev
Log:
Fix -Woverloaded-virtual warning in clang-refactor
Modified:
cfe/trunk/tools/clang-refactor/ClangRefactor.cpp
Modified: cfe/trunk/tools/clang-refactor/ClangR
