Re: r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-13 Thread Rui Ueyama via cfe-commits
Ah, sorry, you mentioned that. Yes, I think you need it. On Wed, Sep 13, 2017 at 1:00 PM, Rui Ueyama wrote: > This is a wild guess, but don't you need to add `REQUIRES: lld` to your > test if your test depends on lld? I don't think all bots have lld, and if > `ld.lld` is not found, clang prints

Re: r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-13 Thread Rui Ueyama via cfe-commits
This is a wild guess, but don't you need to add `REQUIRES: lld` to your test if your test depends on lld? I don't think all bots have lld, and if `ld.lld` is not found, clang prints out that error message. On Tue, Sep 12, 2017 at 7:16 PM, Martell Malone wrote: > Just to follow up, > The test cas

Re: r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Martell Malone via cfe-commits
Just to follow up, The test case here was added by yaron in https://reviews.llvm.org/rL253066 As a follow up to the original detection which I originally wrote and reid reviewed https://reviews.llvm.org/rL242121 Given that no other target does special checks except msvc for lld-link removing this t

Re: r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Martell Malone via cfe-commits
Hey Reid, Rui, I had to revert this twice. I'm not sure where the configurations for the build bots are but there are 2 issues as I mentioned in the commit message Looking through the clang test directory I only se -fuse-ld=lld tested in 4 locations test/Driver/windows-cross.c does some really o

r313104 - Revert "[Driver] MinGW: Remove custom linker detection"

2017-09-12 Thread Martell Malone via cfe-commits
Author: martell Date: Tue Sep 12 17:57:50 2017 New Revision: 313104 URL: http://llvm.org/viewvc/llvm-project?rev=313104&view=rev Log: Revert "[Driver] MinGW: Remove custom linker detection" This reverts rL313102 because it still fails some build bot tests. On many linux bots it fails with the fo