Re: r312633 - [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

2017-09-11 Thread Alex L via cfe-commits
It's a good idea to merge the two. I'll work on moving the ObjC traversal change when I get the time. Thanks for the quick patches Johannes! On 9 September 2017 at 12:03, Johannes Altmanninger wrote: > Richard Smith writes: > > > I am extremely uncomfortable about the direction this patch seri

Re: r312633 - [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

2017-09-09 Thread Johannes Altmanninger via cfe-commits
Richard Smith writes: > I am extremely uncomfortable about the direction this patch series is going. > > We have had two different RecursiveASTVisitors before (RecursiveASTVisitor > and DataRecursiveASTVisitor), and it was a maintenance nightmare: > frequently changes would be made to one of them

Re: r312633 - [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

2017-09-06 Thread Richard Smith via cfe-commits
I am extremely uncomfortable about the direction this patch series is going. We have had two different RecursiveASTVisitors before (RecursiveASTVisitor and DataRecursiveASTVisitor), and it was a maintenance nightmare: frequently changes would be made to one of them and missed in the other one, res

r312633 - [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor

2017-09-06 Thread Johannes Altmanninger via cfe-commits
Author: krobelus Date: Wed Sep 6 06:12:11 2017 New Revision: 312633 URL: http://llvm.org/viewvc/llvm-project?rev=312633&view=rev Log: [AST] Traverse CXXOperatorCallExpr in LexicallyOrderedRecursiveASTVisitor Summary: This affects overloaded operators, which are represented by a CXXOperatorCallEx