Hey Hans,
Just a heads up that I fixed the issue and reapplies the commit in r312512.
Let me know if any new issues occur! (and feel free to revert of course).
Thanks,
--
Mehdi
2017-08-28 14:18 GMT-07:00 Mehdi AMINI :
> Sorry for the inconvenience!
>
> I will follow-up in the PR.
>
> --
> Meh
Sorry for the inconvenience!
I will follow-up in the PR.
--
Mehdi
2017-08-28 12:42 GMT-07:00 Hans Wennborg :
> I reverted this in r311898 as it caused Chromium builds to fail with
> an assertion; see PR34348.
>
> On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Amini via cfe-commits
> wrote:
> > Autho
I reverted this in r311898 as it caused Chromium builds to fail with
an assertion; see PR34348.
On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Amini via cfe-commits
wrote:
> Author: mehdi_amini
> Date: Sun Aug 27 13:24:09 2017
> New Revision: 311857
>
> URL: http://llvm.org/viewvc/llvm-project?rev=311857
Author: hans
Date: Mon Aug 28 10:53:00 2017
New Revision: 311898
URL: http://llvm.org/viewvc/llvm-project?rev=311898&view=rev
Log:
Revert r311857 "Emit static constexpr member as available_externally definition"
It caused PR759744.
> Emit static constexpr member as ava
Author: mehdi_amini
Date: Sun Aug 27 13:24:09 2017
New Revision: 311857
URL: http://llvm.org/viewvc/llvm-project?rev=311857&view=rev
Log:
Emit static constexpr member as available_externally definition
By exposing the constant initializer, the optimizer can fold many
of these constructs.
Differe
