Are the pshpack1.h/poppack.h headers included from other headers in the SDK
or are they intended for end-users? If they're only used in the SDK then
the SDK headers should probably be system headers, so the warning should be
silenced.
Apart from that there's no real good solution for this issue un
Another bit of feedback: The Microsoft SDK has pragma adjustment headers
that are used like so:
#include
// Define structs with alignment 1 here
#include
This warning fires on that. I haven't seen these headers in active use
recently, but I remember seeing them quite a bit maybe 10 years ago. (
Add a note with a fixit in r309559.
On 31 July 2017 at 10:50, Alex L wrote:
> That's an interesting case. I'll tweak the warning to diagnose this
> scenario better today.
>
> On 29 July 2017 at 00:56, Hans Wennborg wrote:
>
>> On Fri, Jul 28, 2017 at 7:41 AM, Alex Lorenz via cfe-commits
>> wro
That's an interesting case. I'll tweak the warning to diagnose this
scenario better today.
On 29 July 2017 at 00:56, Hans Wennborg wrote:
> On Fri, Jul 28, 2017 at 7:41 AM, Alex Lorenz via cfe-commits
> wrote:
> > Author: arphaman
> > Date: Fri Jul 28 07:41:21 2017
> > New Revision: 309386
> >
On Fri, Jul 28, 2017 at 7:41 AM, Alex Lorenz via cfe-commits
wrote:
> Author: arphaman
> Date: Fri Jul 28 07:41:21 2017
> New Revision: 309386
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309386&view=rev
> Log:
> Recommit r308327 3rd time: Add a warning for missing
> '#pragma pack (pop)' and s
Author: arphaman
Date: Fri Jul 28 07:41:21 2017
New Revision: 309386
URL: http://llvm.org/viewvc/llvm-project?rev=309386&view=rev
Log:
Recommit r308327 3rd time: Add a warning for missing
'#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files
The second recommit (r309106) wa
